You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@roller.apache.org by sn...@apache.org on 2026/09/27 19:52:22 UTC

(roller) branch master updated: No single quotes in media file insert url on mediaFileAdd!save.rol (#193)

This is an automated email from the ASF dual-hosted git repository.

snoopdave pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/roller.git


The following commit(s) were added to refs/heads/master by this push:
     new 9f408a21e No single quotes in media file insert url on mediaFileAdd!save.rol (#193)
9f408a21e is described below

commit 9f408a21e4dfb851d978c63727fcd3fea9360bf3
Author: gregh3269 <gr...@gmail.com>
AuthorDate: Sun Sep 27 20:52:17 2026 +0100

    No single quotes in media file insert url on mediaFileAdd!save.rol (#193)
    
    Co-authored-by: Greg Huber <gh...@apache.org>
---
 .../roller/weblogger/ui/struts2/editor/EntryAddWithMediaFile.java   | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/app/src/main/java/org/apache/roller/weblogger/ui/struts2/editor/EntryAddWithMediaFile.java b/app/src/main/java/org/apache/roller/weblogger/ui/struts2/editor/EntryAddWithMediaFile.java
index 600d6276d..23c02712b 100644
--- a/app/src/main/java/org/apache/roller/weblogger/ui/struts2/editor/EntryAddWithMediaFile.java
+++ b/app/src/main/java/org/apache/roller/weblogger/ui/struts2/editor/EntryAddWithMediaFile.java
@@ -80,14 +80,14 @@ public class EntryAddWithMediaFile extends MediaFileBase {
 
                     if (mediaFile.isImageFile()) {
                         link = "<p>" + mediaFile.getName() + "</p>";
-                        link += "<a href='<url>'><img src='<urlt>' alt='<name>' width='<width>' height='<height>'></img></a>";
+                        link += "<a href=\"<url>\"><img src=\"<urlt>\" alt=\"<name>\" width=\"<width>\" height=\"<height>\"></img></a>";
                         link = link.replace("<url>", mediaFile.getPermalink())
                                    .replace("<urlt>", mediaFile.getThumbnailURL())
                                    .replace("<name>", mediaFile.getName())
                                    .replace("<width>", ""+mediaFile.getThumbnailWidth())
                                    .replace("<height>", ""+mediaFile.getThumbnailHeight());
                     } else {
-                        link = "<a href='<url>'><name></a> (<size> bytes, <type>)";
+                        link = "<a href=\"<url>\"><name></a> (<size> bytes, <type>)";
                         link = link.replace("<url>", mediaFile.getPermalink())
                                    .replace("<name>", mediaFile.getName())
                                    .replace("<size>",""+mediaFile.getLength())
@@ -101,7 +101,7 @@ public class EntryAddWithMediaFile extends MediaFileBase {
                 sb.append("<p>")
                   .append(getText("mediaFileEdit.includesEnclosure"))
                   .append("<br />")
-                  .append("<a href='" + bean.getEnclosureURL() + "'>")
+                  .append("<a href=\"" + bean.getEnclosureURL() + "\">")
                   .append(bean.getEnclosureURL())
                   .append("</a></p>");
             }