You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/03/08 09:43:09 UTC
[GitHub] [flink] honnix opened a new pull request #19009: [hotfix] [docs] Refer to Running in an IDE section early on
honnix opened a new pull request #19009:
URL: https://github.com/apache/flink/pull/19009
## What is the purpose of the change
When following this doc, I found myself searching on Google instead of reading the final section that is pretty further away. It might be useful to have an early reference.
## Brief change log
Refer to "Running in an IDE" section when we first mentioning running directly inside IDE.
## Verifying this change
This change is a trivial doc change without any test coverage.
## Does this pull request potentially affect one of the following parts:
NA.
## Documentation
NA.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] honnix commented on a change in pull request #19009: [hotfix] [docs] Refer to Running in an IDE section early on
Posted by GitBox <gi...@apache.org>.
honnix commented on a change in pull request #19009:
URL: https://github.com/apache/flink/pull/19009#discussion_r821491306
##########
File path: docs/content/docs/try-flink/datastream.md
##########
@@ -902,4 +903,4 @@ You should see the following output in your task manager logs:
Running the project in an IDE may result in a `java.lang.NoClassDefFoundError` exception. This is probably because you do not have all required Flink dependencies implicitly loaded into the classpath.
-* IntelliJ IDEA: Go to Run > Edit Configurations > Modify options > Select `include dependencies with "Provided" scope`. This run configuration will now include all required classes to run the application from within the IDE.
\ No newline at end of file
+* IntelliJ IDEA: Go to Run > Edit Configurations > Modify options > Select `include dependencies with "Provided" scope`. This run configuration will now include all required classes to run the application from within the IDE.
Review comment:
I guess github gets confused. There is no change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #19009: [hotfix] [docs] Refer to Running in an IDE section early on
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #19009:
URL: https://github.com/apache/flink/pull/19009#issuecomment-1061628385
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "282572e53fc0db37c831a9486742e1b5a51663e0",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32681",
"triggerID" : "282572e53fc0db37c831a9486742e1b5a51663e0",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 282572e53fc0db37c831a9486742e1b5a51663e0 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32681)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #19009: [hotfix] [docs] Refer to Running in an IDE section early on
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #19009:
URL: https://github.com/apache/flink/pull/19009#issuecomment-1061628385
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "282572e53fc0db37c831a9486742e1b5a51663e0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32681",
"triggerID" : "282572e53fc0db37c831a9486742e1b5a51663e0",
"triggerType" : "PUSH"
}, {
"hash" : "e05693bd5f073885a2db29f0a06ee48d9463fb1f",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32715",
"triggerID" : "e05693bd5f073885a2db29f0a06ee48d9463fb1f",
"triggerType" : "PUSH"
}, {
"hash" : "ed4e5fdc3e27bd4cc6046d7d5c485fd3820be998",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "ed4e5fdc3e27bd4cc6046d7d5c485fd3820be998",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* e05693bd5f073885a2db29f0a06ee48d9463fb1f Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32715)
* ed4e5fdc3e27bd4cc6046d7d5c485fd3820be998 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #19009: [hotfix] [docs] Refer to Running in an IDE section early on
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #19009:
URL: https://github.com/apache/flink/pull/19009#issuecomment-1061628385
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "282572e53fc0db37c831a9486742e1b5a51663e0",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32681",
"triggerID" : "282572e53fc0db37c831a9486742e1b5a51663e0",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 282572e53fc0db37c831a9486742e1b5a51663e0 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32681)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] MartijnVisser commented on pull request #19009: [hotfix] [docs] Refer to Running in an IDE section early on
Posted by GitBox <gi...@apache.org>.
MartijnVisser commented on pull request #19009:
URL: https://github.com/apache/flink/pull/19009#issuecomment-1061714622
@slinkydeveloper What do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] honnix commented on pull request #19009: [hotfix] [docs] Refer to Running in an IDE section early on
Posted by GitBox <gi...@apache.org>.
honnix commented on pull request #19009:
URL: https://github.com/apache/flink/pull/19009#issuecomment-1064077996
I made the Chinese translation in https://github.com/apache/flink/pull/19044
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] honnix commented on pull request #19009: [hotfix] [docs] Refer to Running in an IDE section early on
Posted by GitBox <gi...@apache.org>.
honnix commented on pull request #19009:
URL: https://github.com/apache/flink/pull/19009#issuecomment-1064045989
Looks like this has been fixed by https://github.com/apache/flink/commit/b800fb2767d570f566269aed9869af9d71c6adba already in main branch. I guess I reached to `release-1.14` branch by following the link in the rendered doc.
Closing this. Thanks for the help and sorry for the confusion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #19009: [hotfix] [docs] Refer to Running in an IDE section early on
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #19009:
URL: https://github.com/apache/flink/pull/19009#issuecomment-1061628385
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "282572e53fc0db37c831a9486742e1b5a51663e0",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "282572e53fc0db37c831a9486742e1b5a51663e0",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 282572e53fc0db37c831a9486742e1b5a51663e0 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #19009: [hotfix] [docs] Refer to Running in an IDE section early on
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #19009:
URL: https://github.com/apache/flink/pull/19009#issuecomment-1061628385
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "282572e53fc0db37c831a9486742e1b5a51663e0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32681",
"triggerID" : "282572e53fc0db37c831a9486742e1b5a51663e0",
"triggerType" : "PUSH"
}, {
"hash" : "e05693bd5f073885a2db29f0a06ee48d9463fb1f",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32715",
"triggerID" : "e05693bd5f073885a2db29f0a06ee48d9463fb1f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* e05693bd5f073885a2db29f0a06ee48d9463fb1f Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32715)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] honnix commented on pull request #19009: [hotfix] [docs] Refer to Running in an IDE section early on
Posted by GitBox <gi...@apache.org>.
honnix commented on pull request #19009:
URL: https://github.com/apache/flink/pull/19009#issuecomment-1064035637
@MartijnVisser Thanks for the suggestions.
I didn't realize it targets `release-1.14`. I will re-target it.
I can do the Chinese translation. Thanks for the reminder.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] MartijnVisser removed a comment on pull request #19009: [hotfix] [docs] Refer to Running in an IDE section early on
Posted by GitBox <gi...@apache.org>.
MartijnVisser removed a comment on pull request #19009:
URL: https://github.com/apache/flink/pull/19009#issuecomment-1061714622
@slinkydeveloper What do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] honnix commented on a change in pull request #19009: [hotfix] [docs] Refer to Running in an IDE section early on
Posted by GitBox <gi...@apache.org>.
honnix commented on a change in pull request #19009:
URL: https://github.com/apache/flink/pull/19009#discussion_r822387261
##########
File path: docs/content/docs/try-flink/datastream.md
##########
@@ -120,6 +120,7 @@ You can edit the `groupId`, `artifactId` and `package` if you like. With the abo
Maven will create a folder named `frauddetection` that contains a project with all the dependencies to complete this tutorial.
After importing the project into your editor, you can find a file `FraudDetectionJob.java` (or `FraudDetectionJob.scala`) with the following code which you can run directly inside your IDE.
Try setting break points through out the data stream and run the code in DEBUG mode to get a feeling for how everything works.
+Having trouble running directly inside your IDE? Please read the section [Running in an IDE](#running-in-an-ide).
Review comment:
Sure.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] MartijnVisser commented on pull request #19009: [hotfix] [docs] Refer to Running in an IDE section early on
Posted by GitBox <gi...@apache.org>.
MartijnVisser commented on pull request #19009:
URL: https://github.com/apache/flink/pull/19009#issuecomment-1061714894
@infoverload @slinkydeveloper What do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] slinkydeveloper commented on a change in pull request #19009: [hotfix] [docs] Refer to Running in an IDE section early on
Posted by GitBox <gi...@apache.org>.
slinkydeveloper commented on a change in pull request #19009:
URL: https://github.com/apache/flink/pull/19009#discussion_r822385904
##########
File path: docs/content/docs/try-flink/datastream.md
##########
@@ -120,6 +120,7 @@ You can edit the `groupId`, `artifactId` and `package` if you like. With the abo
Maven will create a folder named `frauddetection` that contains a project with all the dependencies to complete this tutorial.
After importing the project into your editor, you can find a file `FraudDetectionJob.java` (or `FraudDetectionJob.scala`) with the following code which you can run directly inside your IDE.
Try setting break points through out the data stream and run the code in DEBUG mode to get a feeling for how everything works.
+Having trouble running directly inside your IDE? Please read the section [Running in an IDE](#running-in-an-ide).
Review comment:
I don't like the "Having trouble" wording. Maybe just "If you wanna run directly in you IDE, please read the section..."
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #19009: [hotfix] [docs] Refer to Running in an IDE section early on
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #19009:
URL: https://github.com/apache/flink/pull/19009#issuecomment-1061628385
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "282572e53fc0db37c831a9486742e1b5a51663e0",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32681",
"triggerID" : "282572e53fc0db37c831a9486742e1b5a51663e0",
"triggerType" : "PUSH"
}, {
"hash" : "e05693bd5f073885a2db29f0a06ee48d9463fb1f",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "e05693bd5f073885a2db29f0a06ee48d9463fb1f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 282572e53fc0db37c831a9486742e1b5a51663e0 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32681)
* e05693bd5f073885a2db29f0a06ee48d9463fb1f UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #19009: [hotfix] [docs] Refer to Running in an IDE section early on
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #19009:
URL: https://github.com/apache/flink/pull/19009#issuecomment-1061628385
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "282572e53fc0db37c831a9486742e1b5a51663e0",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32681",
"triggerID" : "282572e53fc0db37c831a9486742e1b5a51663e0",
"triggerType" : "PUSH"
}, {
"hash" : "e05693bd5f073885a2db29f0a06ee48d9463fb1f",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32715",
"triggerID" : "e05693bd5f073885a2db29f0a06ee48d9463fb1f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 282572e53fc0db37c831a9486742e1b5a51663e0 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32681)
* e05693bd5f073885a2db29f0a06ee48d9463fb1f Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32715)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] MartijnVisser commented on a change in pull request #19009: [hotfix] [docs] Refer to Running in an IDE section early on
Posted by GitBox <gi...@apache.org>.
MartijnVisser commented on a change in pull request #19009:
URL: https://github.com/apache/flink/pull/19009#discussion_r823692647
##########
File path: docs/content/docs/try-flink/datastream.md
##########
@@ -120,6 +120,7 @@ You can edit the `groupId`, `artifactId` and `package` if you like. With the abo
Maven will create a folder named `frauddetection` that contains a project with all the dependencies to complete this tutorial.
After importing the project into your editor, you can find a file `FraudDetectionJob.java` (or `FraudDetectionJob.scala`) with the following code which you can run directly inside your IDE.
Try setting break points through out the data stream and run the code in DEBUG mode to get a feeling for how everything works.
+If you want to run directly in you IDE, please read the section [Running in an IDE](#running-in-an-ide).
Review comment:
```suggestion
Please read the section [Running in an IDE](#running-in-an-ide) for all details on how to run Flink applications in your IDE.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] honnix closed pull request #19009: [hotfix] [docs] Refer to Running in an IDE section early on
Posted by GitBox <gi...@apache.org>.
honnix closed pull request #19009:
URL: https://github.com/apache/flink/pull/19009
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org