You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by dpogue <gi...@git.apache.org> on 2016/10/12 18:13:42 UTC
[GitHub] cordova-ios pull request #269: CB-12002 - Support LSApplicationQueriesScheme...
GitHub user dpogue opened a pull request:
https://github.com/apache/cordova-ios/pull/269
CB-12002 - Support LSApplicationQueriesSchemes
\u26a0\ufe0f Depends on https://github.com/apache/cordova-lib/pull/502
### Platforms affected
iOS
### What does this PR do?
Adds support for parsing `<allow-intent>` tags in config.xml and creating a list of allowed schemes to be written as `LSApplicationQueriesSchemes` in the Info.plist.
For more info about LSApplicationQueriesSchemes, see https://developer.apple.com/library/content/documentation/General/Reference/InfoPlistKeyReference/Articles/LaunchServicesKeys.html#//apple_ref/doc/uid/TP40009250-SW14
### What testing has been done on this change?
Added spec test.
### Checklist
- [x] Reported an issue in the JIRA database: [CB-12002](https://issues.apache.org/jira/browse/CB-12002)
- [x] Commit message follows the format.
- [x] Added automated test coverage as appropriate for this change.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/dpogue/cordova-ios allow-intent
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-ios/pull/269.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #269
----
commit 374e5741ad569ab380217926f0f23d54d4ea628d
Author: Darryl Pogue <da...@ayogo.com>
Date: 2016-10-12T18:09:57Z
CB-12002 - Support LSApplicationQueriesSchemes
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-ios issue #269: CB-12002 - Support LSApplicationQueriesSchemes
Posted by shazron <gi...@git.apache.org>.
Github user shazron commented on the issue:
https://github.com/apache/cordova-ios/pull/269
The dependent changes will be in the cordova-common 1.5.1 release, and will be integrated as soon as it is released.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-ios issue #269: CB-12002 - Support LSApplicationQueriesSchemes
Posted by shazron <gi...@git.apache.org>.
Github user shazron commented on the issue:
https://github.com/apache/cordova-ios/pull/269
Yeah looks like openURL does not need the key: https://developer.apple.com/reference/uikit/uiapplication/1622952-canopenurl
(see last paragraph -- it has a typo, UIDefaultLaunchStoryboard should be LSApplicationQueriesSchemes
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-ios issue #269: CB-12002 - Support LSApplicationQueriesSchemes
Posted by shazron <gi...@git.apache.org>.
Github user shazron commented on the issue:
https://github.com/apache/cordova-ios/pull/269
@dpogue Can you rebase? cordova-common 1.5.1 is in the repo now
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-ios issue #269: CB-12002 - Support LSApplicationQueriesSchemes
Posted by jcesarmobile <gi...@git.apache.org>.
Github user jcesarmobile commented on the issue:
https://github.com/apache/cordova-ios/pull/269
I commented this on the issue
> LSApplicationQueriesSchemes is only needed for canOpenURL, but we use openURL without querying if it can be opened first. That opened the apps if they were on the allow-intent (worked on iOS 9 and earlier, but didn't test on iOS 10)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-ios issue #269: CB-12002 - Support LSApplicationQueriesSchemes
Posted by shazron <gi...@git.apache.org>.
Github user shazron commented on the issue:
https://github.com/apache/cordova-ios/pull/269
So if they use `canOpenURL` they need this, but if they just use `openURL`, like our whitelist system, we don't. Therefore I believe our whitelist system with `<allow-intent>` does not need these keys.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-ios issue #269: CB-12002 - Support LSApplicationQueriesSchemes
Posted by dpogue <gi...@git.apache.org>.
Github user dpogue commented on the issue:
https://github.com/apache/cordova-ios/pull/269
hmm, I think in our case we were trying to use canOpenURL to see if a partner app was able to launch and redirect to the store otherwise. This also came up in the Slack channel recently, and was mentioned in some Github threads on notification plugins trying to launch mailto links.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-ios issue #269: CB-12002 - Support LSApplicationQueriesSchemes
Posted by codecov-io <gi...@git.apache.org>.
Github user codecov-io commented on the issue:
https://github.com/apache/cordova-ios/pull/269
## [Current coverage](https://codecov.io/gh/apache/cordova-ios/pull/269?src=pr) is 60.55% (diff: 100%)
> Merging [#269](https://codecov.io/gh/apache/cordova-ios/pull/269?src=pr) into [master](https://codecov.io/gh/apache/cordova-ios/branch/master?src=pr) will increase coverage by **0.23%**
```diff
@@ master #269 diff @@
==========================================
Files 12 12
Lines 1318 1326 +8
Methods 200 201 +1
Messages 0 0
Branches 223 225 +2
==========================================
+ Hits 795 803 +8
Misses 523 523
Partials 0 0
```
> Powered by [Codecov](https://codecov.io?src=pr). Last update [aa87d30...a661b63](https://codecov.io/gh/apache/cordova-ios/compare/aa87d308a1384da1e05dad33e9dbae2f0ce5c065...a661b638bd552d68106db9db34210318a7dfc1fe?src=pr)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-ios issue #269: CB-12002 - Support LSApplicationQueriesSchemes
Posted by jcesarmobile <gi...@git.apache.org>.
Github user jcesarmobile commented on the issue:
https://github.com/apache/cordova-ios/pull/269
We where using canOpenURL on inAppBrowser plugin, but I removed it to fix CB-11178 as we weren't really sending any response to the user if canOpenURL was false.
I don't think it's a good idea to add all the allow-intent schemes into the LSApplicationQueriesSchemes, as not all are needed to be there (as http or https), also, the PR doesn't handle the case of a duplicate scheme, as you can put multiple urls starting by http in allow intent tags and this will add http protocol multiple times.
As we are going to allow to write into the info.plist from the config.xml soon, and we don't use canOpenURL on cordova-ios, I don't think this should be merged.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org