You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ofbiz.apache.org by "golja (via GitHub)" <gi...@apache.org> on 2026/04/17 17:00:40 UTC
[PR] Fixed: Add license header to ServiceContextCleanupFilter.java [ofbiz-plugins]
golja opened a new pull request, #208:
URL: https://github.com/apache/ofbiz-plugins/pull/208
In the [output](https://nightlies.apache.org/ofbiz/trunk/rat-output.html) of the latest run of the buildbot builder ofbizTrunkFrameworkRat, it is reported that the file
rest-api/src/main/java/org/apache/ofbiz/ws/rs/filters/ServiceContextCleanupFilter.java
has an unapproved license. The reason is that the license header is missing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ofbiz.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fixed: Add license header to ServiceContextCleanupFilter.java [ofbiz-plugins]
Posted by "JacquesLeRoux (via GitHub)" <gi...@apache.org>.
JacquesLeRoux commented on PR #208:
URL: https://github.com/apache/ofbiz-plugins/pull/208#issuecomment-4282678797
Ah, Jacopo closed it: https://github.com/apache/ofbiz-framework/pull/1122
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ofbiz.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fixed: Add license header to ServiceContextCleanupFilter.java [ofbiz-plugins]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #208:
URL: https://github.com/apache/ofbiz-plugins/pull/208#issuecomment-4269856241
## [](https://sonarcloud.io/dashboard?id=apache_ofbiz-plugins&pullRequest=208) **Quality Gate passed**
Issues
 [0 New issues](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins&pullRequest=208&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins&pullRequest=208&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-plugins&pullRequest=208&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_ofbiz-plugins&pullRequest=208&metric=new_coverage&view=list)
 [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_ofbiz-plugins&pullRequest=208&metric=new_duplicated_lines_density&view=list)
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_ofbiz-plugins&pullRequest=208)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ofbiz.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fixed: Add license header to ServiceContextCleanupFilter.java [ofbiz-plugins]
Posted by "JacquesLeRoux (via GitHub)" <gi...@apache.org>.
JacquesLeRoux commented on PR #208:
URL: https://github.com/apache/ofbiz-plugins/pull/208#issuecomment-4282670683
Hi @golja ,
Yes I know, I added them all Saturday around 9AM, that's why I closed this PR. I don't remember for the framework PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ofbiz.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fixed: Add license header to ServiceContextCleanupFilter.java [ofbiz-plugins]
Posted by "JacquesLeRoux (via GitHub)" <gi...@apache.org>.
JacquesLeRoux closed pull request #208: Fixed: Add license header to ServiceContextCleanupFilter.java
URL: https://github.com/apache/ofbiz-plugins/pull/208
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ofbiz.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fixed: Add license header to ServiceContextCleanupFilter.java [ofbiz-plugins]
Posted by "JacquesLeRoux (via GitHub)" <gi...@apache.org>.
JacquesLeRoux commented on PR #208:
URL: https://github.com/apache/ofbiz-plugins/pull/208#issuecomment-4273262933
Thanks Anahita,
There is also UtilCacheTest.groovy, UtilCacheTestTools.groovy and ServiceContextCleanupFilter.java. I have fixed them directly (easier than adding to your PR) before pushing this PR.
There is also pdftest2.pdf. [I have asked Infra about that](https://issues.apache.org/jira/browse/INFRA-27827).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ofbiz.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fixed: Add license header to ServiceContextCleanupFilter.java [ofbiz-plugins]
Posted by "JacquesLeRoux (via GitHub)" <gi...@apache.org>.
JacquesLeRoux commented on PR #208:
URL: https://github.com/apache/ofbiz-plugins/pull/208#issuecomment-4282684365
You were right for me mixing framework and plugins, sorry.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ofbiz.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fixed: Add license header to ServiceContextCleanupFilter.java [ofbiz-plugins]
Posted by "golja (via GitHub)" <gi...@apache.org>.
golja commented on PR #208:
URL: https://github.com/apache/ofbiz-plugins/pull/208#issuecomment-4279091336
> Thanks Anahita,
>
> There is also UtilCacheTest.groovy, UtilCacheTestTools.groovy and ServiceContextCleanupFilter.java. I have fixed them directly (easier than adding to your PR) before pushing this PR.
>
> There is also pdftest2.pdf. [I have asked Infra about that](https://issues.apache.org/jira/browse/INFRA-27827).
Hi @JacquesLeRoux,
changes to ServiceContextCleanupFilter.java are included in this PR. The other two files you mentioned (UtilCacheTest.groovy, UtilCacheTestTools.groovy) are in the ofbiz-framework repository, not in the ofbiz-plugins repository. That’s why this PR only includes changes to the ServiceContextCleanupFilter.
For your information, alongside this PR I’ve also submitted another PR to ofbiz-framework with changes to the other two files.
Anahita
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ofbiz.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fixed: Add license header to ServiceContextCleanupFilter.java [ofbiz-plugins]
Posted by "JacquesLeRoux (via GitHub)" <gi...@apache.org>.
JacquesLeRoux commented on PR #208:
URL: https://github.com/apache/ofbiz-plugins/pull/208#issuecomment-4273266190
Oops, actually I did also ServiceContextCleanupFilter.java. I close here, sorry :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ofbiz.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org