Re: [PR] RATIS-2322. Upgrade JUnit Jupiter to 5.13.3 and Maven Surefire Plugin to 3.5.3. [ratis]

["adoroszlai (via GitHub)" <gi...@apache.org>]

adoroszlai commented on code in PR #1281:
URL: https://github.com/apache/ratis/pull/1281#discussion_r2355148510


##########
ratis-test/src/test/java/org/apache/ratis/grpc/TestInstallSnapshotNotificationWithGrpc.java:
##########
@@ -18,7 +18,9 @@
 package org.apache.ratis.grpc;
 
 import org.apache.ratis.InstallSnapshotNotificationTests;
+import org.apache.ratis.test.tag.Flaky;
 
+@Flaky("RATIS-2322")

Review Comment:
   This should point to the Jira issue about the intermittent test failure in `TestInstallSnapshotNotificationWithGrpc` (RATIS-2261), not to the JUnit/Surefire upgrade task.



##########
ratis-server/src/test/java/org/apache/ratis/WatchRequestTests.java:
##########
@@ -302,7 +302,6 @@ static void checkAll(List<CompletableFuture<WatchReplies>> watches, Logger log)
       final WatchReplies watchReplies = watches.get(i).get(GET_TIMEOUT_SECOND, TimeUnit.SECONDS);
       final long logIndex = watchReplies.logIndex;
       log.info("checkAll {}: logIndex={}", i, logIndex);
-      final RaftClientReply watchAllReply = watchReplies.getAll();

Review Comment:
   Can you please explain why this is needed?  (I see the `NullPointerException` in `TestWatchRequestWithGrpc.testWatchRequestAsyncChangeLeader` [here](https://github.com/apache/ratis/actions/runs/17016369486/job/48239546365#step:11:779), but would like to know what causes it.)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org