You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Grant Henke (Code Review)" <ge...@cloudera.org> on 2018/02/13 20:20:53 UTC

[kudu-CR] [Java] Downgrade protobuf to 3.4.0

Grant Henke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9304


Change subject: [Java] Downgrade protobuf to 3.4.0
......................................................................

[Java] Downgrade protobuf to 3.4.0

The recent bump in the Protobuf version breaks el6
compatibility due to a bug in the Maven delpoyed
protoc artifacts.

This patch downgrades to the latest compatible version
and adds the issue url for tracking.

https://github.com/google/protobuf/issues/4109

Change-Id: I1c23138bb030a3d5069dd8efa9e7231c3f2fd339
---
M java/gradle/dependencies.gradle
M java/pom.xml
2 files changed, 6 insertions(+), 2 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/04/9304/1
-- 
To view, visit http://gerrit.cloudera.org:8080/9304
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I1c23138bb030a3d5069dd8efa9e7231c3f2fd339
Gerrit-Change-Number: 9304
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@gmail.com>

[kudu-CR] [Java] Downgrade protobuf to 3.4.0

Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/9304 )

Change subject: [Java] Downgrade protobuf to 3.4.0
......................................................................


Patch Set 1: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/9304
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1c23138bb030a3d5069dd8efa9e7231c3f2fd339
Gerrit-Change-Number: 9304
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Tue, 13 Feb 2018 20:34:16 +0000
Gerrit-HasComments: No

[kudu-CR] [Java] Downgrade protobuf to 3.4.0

Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9304 )

Change subject: [Java] Downgrade protobuf to 3.4.0
......................................................................

[Java] Downgrade protobuf to 3.4.0

The recent bump in the Protobuf version breaks el6
compatibility due to a bug in the Maven delpoyed
protoc artifacts.

This patch downgrades to the latest compatible version
and adds the issue url for tracking.

https://github.com/google/protobuf/issues/4109

Change-Id: I1c23138bb030a3d5069dd8efa9e7231c3f2fd339
Reviewed-on: http://gerrit.cloudera.org:8080/9304
Reviewed-by: Todd Lipcon <to...@apache.org>
Tested-by: Kudu Jenkins
---
M java/gradle/dependencies.gradle
M java/pom.xml
2 files changed, 6 insertions(+), 2 deletions(-)

Approvals:
  Todd Lipcon: Looks good to me, approved
  Kudu Jenkins: Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/9304
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I1c23138bb030a3d5069dd8efa9e7231c3f2fd339
Gerrit-Change-Number: 9304
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@gmail.com>
Gerrit-Reviewer: Grant Henke <gr...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>