[jira] [Commented] (SENTRY-1665) cross-site scripting vulnerability in ConfServlet

["Brian Towles (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SENTRY-1665?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16057666#comment-16057666 ] 

Brian Towles commented on SENTRY-1665:
--------------------------------------

Looks like we can simply escape the output with an HTML escape.  Im going to use the one in commons-lang since it already is part of the overall project, but it will add it as a dependency to sentry-provider-db directly.

> cross-site scripting vulnerability in ConfServlet
> -------------------------------------------------
>
>                 Key: SENTRY-1665
>                 URL: https://issues.apache.org/jira/browse/SENTRY-1665
>             Project: Sentry
>          Issue Type: Bug
>          Components: Sentry
>    Affects Versions: 1.8.0
>            Reporter: Alexander Kolbasov
>            Assignee: Brian Towles
>              Labels: bite-sized, newbie, security
>
> The ConfServlet class has the following code:
> {code}
>     String format = request.getParameter(FORMAT_PARAM);
>     ...
>     } else {
>       response.sendError(HttpServletResponse.SC_BAD_REQUEST, "Bad format: " + format);
>     }
> {code}
> As a result HTTP parameter is directly written to Servlet error page.  Echoing this untrusted input allows for a reflected cross site scripting vulnerability. See http://en.wikipedia.org/wiki/Cross-site_scripting for more information.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)