You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by brodybits <gi...@git.apache.org> on 2017/03/15 22:23:11 UTC
[GitHub] cordova-lib pull request #528: CB-12572: (windows) pin cordova-windows 5.0.0
GitHub user brodybits opened a pull request:
https://github.com/apache/cordova-lib/pull/528
CB-12572: (windows) pin cordova-windows 5.0.0
<!--
Please make sure the checklist boxes are all checked before submitting the PR. The checklist
is intended as a quick reference, for complete details please see our Contributor Guidelines:
http://cordova.apache.org/contribute/contribute_guidelines.html
Thanks!
-->
### Platforms affected
Windows
### What does this PR do?
[CB-12572](https://issues.apache.org/jira/browse/CB-12572): use cordova-windows 5.0.0
This is needed to support Windows plugin WinMD+DLL combinations ([CB-12189](https://issues.apache.org/jira/browse/CB-12189)).
### What testing has been done on this change?
- Install cordova-lib with this change in a local checkout of cordova-cli
- Do npm install of the local cordova-cli in a test directory
- Use the local cordova-cli to add the Windows platform to a local checkout of <https://github.com/brodybits/cordova-dialogs-bootstrap-test>
- do `cordova platform ls` to verify that cordova-windows 5.0.0 was used
- Build and run as both desktop and mobile app (using Visual Studio 2015)
I do not think there is any need to update the automatic test suite. Please correct me in case I am mistaken.
### Checklist
- [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database
- [X] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
- [ ] ~~Added automated test coverage as appropriate for this change.~~
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/brodybits/cordova-lib cb-12572
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-lib/pull/528.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #528
----
commit 391f23745be27633c6afadae227f275682699cf0
Author: Christopher J. Brody <br...@litehelpers.net>
Date: 2017-03-15T22:02:28Z
CB-12572: (windows) pin cordova-windows 5.0.0
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib issue #528: CB-12572: (windows) pin cordova-windows 5.0.0
Posted by brodybits <gi...@git.apache.org>.
Github user brodybits commented on the issue:
https://github.com/apache/cordova-lib/pull/528
@stevengill when do you expect this to be released?
I think we still have to update cordova-cli to reference a version of cordova-lib with this fix. I would be happy to contribute the cordova-cli update once this fix is released.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib issue #528: CB-12572: (windows) pin cordova-windows 5.0.0
Posted by stevengill <gi...@git.apache.org>.
Github user stevengill commented on the issue:
https://github.com/apache/cordova-lib/pull/528
We are currently prepping for the cordova@7 release. Cordova-cli will get
updated to use cordova-lib during that release process.
On Tue, Mar 21, 2017 at 4:21 PM, Christopher J. Brody <
notifications@github.com> wrote:
> @stevengill <https://github.com/stevengill> when do you expect this to be
> released?
>
> I think we still have to update cordova-cli to reference a version of
> cordova-lib with this fix. I would be happy to contribute the cordova-cli
> update once this fix is released.
>
> \u2014
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/cordova-lib/pull/528#issuecomment-288250182>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/AAKWQGHVRb_mSV4HMnTeWt8gJ0lhPdV3ks5roFt8gaJpZM4Mem01>
> .
>
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib issue #528: CB-12572: (windows) pin cordova-windows 5.0.0
Posted by brodybits <gi...@git.apache.org>.
Github user brodybits commented on the issue:
https://github.com/apache/cordova-lib/pull/528
Thanks @stevengill!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib issue #528: CB-12572: (windows) pin cordova-windows 5.0.0
Posted by codecov-io <gi...@git.apache.org>.
Github user codecov-io commented on the issue:
https://github.com/apache/cordova-lib/pull/528
# [Codecov](https://codecov.io/gh/apache/cordova-lib/pull/528?src=pr&el=h1) Report
> Merging [#528](https://codecov.io/gh/apache/cordova-lib/pull/528?src=pr&el=desc) into [master](https://codecov.io/gh/apache/cordova-lib/commit/07001dc4e0acf89358c50791589428615198286b?src=pr&el=desc) will **decrease** coverage by `0.01%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #528 +/- ##
==========================================
- Coverage 81.9% 81.88% -0.02%
==========================================
Files 68 68
Lines 5498 5498
Branches 1090 1090
==========================================
- Hits 4503 4502 -1
- Misses 995 996 +1
```
| [Impacted Files](https://codecov.io/gh/apache/cordova-lib/pull/528?src=pr&el=tree) | Coverage \u0394 | |
|---|---|---|
| [cordova-lib/src/platforms/PlatformApiPoly.js](https://codecov.io/gh/apache/cordova-lib/compare/07001dc4e0acf89358c50791589428615198286b...391f23745be27633c6afadae227f275682699cf0?src=pr&el=tree#diff-Y29yZG92YS1saWIvc3JjL3BsYXRmb3Jtcy9QbGF0Zm9ybUFwaVBvbHkuanM=) | `93.79% <0%> (-0.39%)` | :x: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-lib/pull/528?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `\u0394 = absolute <relative> (impact)`, `� = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/cordova-lib/pull/528?src=pr&el=footer). Last update [07001dc...391f237](https://codecov.io/gh/apache/cordova-lib/compare/07001dc4e0acf89358c50791589428615198286b...391f23745be27633c6afadae227f275682699cf0?el=footer&src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib pull request #528: CB-12572: (windows) pin cordova-windows 5.0.0
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-lib/pull/528
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org