You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by "essobedo (via GitHub)" <gi...@apache.org> on 2023/05/30 09:00:38 UTC
[GitHub] [camel] essobedo opened a new pull request, #10238: CAMEL-19402: test-infra - Reduce the boilerplate code needed
essobedo opened a new pull request, #10238:
URL: https://github.com/apache/camel/pull/10238
Fixes https://issues.apache.org/jira/browse/CAMEL-19402
## Motivation
There is some duplicated code in test-infra. The goal of these changes is to reduce the boilerplate code needed to add a new service.
## Modifications:
* Move the default implementation of the `beforeAll` and `afterAll` callbacks in `TestService` as it is always the same
* Move the default implementation of the singleton `beforeAll` and `afterAll` callbacks in SingletonService as it is always the same
* Apply [initialization-on-demand holder idiom](https://en.wikipedia.org/wiki/Initialization-on-demand_holder_idiom) to initialize the `SingletonService` instances
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] essobedo commented on pull request #10238: CAMEL-19402: test-infra - Reduce the boilerplate code needed
Posted by "essobedo (via GitHub)" <gi...@apache.org>.
essobedo commented on PR #10238:
URL: https://github.com/apache/camel/pull/10238#issuecomment-1568301006
@orpiske by chance, do you have the failures? I've just tested the `Consul` and `Kafka` components, the tests pass with success
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] orpiske commented on pull request #10238: CAMEL-19402: test-infra - Reduce the boilerplate code needed
Posted by "orpiske (via GitHub)" <gi...@apache.org>.
orpiske commented on PR #10238:
URL: https://github.com/apache/camel/pull/10238#issuecomment-1568258642
Running the tests manually, the following components had errors:
* Consul
* Kafka
* JDBC
* MongoDB
* Redis
* Nats
* Pulsar
* Xmpp
* Zookeeper
* Zookeeper Master
In case you want to try it on your end, I used this script to test: https://gist.github.com/orpiske/690f343a7f913dbae9a6d6d278da715d
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] essobedo commented on pull request #10238: CAMEL-19402: test-infra - Reduce the boilerplate code needed
Posted by "essobedo (via GitHub)" <gi...@apache.org>.
essobedo commented on PR #10238:
URL: https://github.com/apache/camel/pull/10238#issuecomment-1568053961
@orpiske WDYT of these small changes in the test-infra code?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] essobedo commented on pull request #10238: CAMEL-19402: test-infra - Reduce the boilerplate code needed
Posted by "essobedo (via GitHub)" <gi...@apache.org>.
essobedo commented on PR #10238:
URL: https://github.com/apache/camel/pull/10238#issuecomment-1570047092
/component-test consul kafka pgevent mongodb redis nats pulsar xmpp zookeeper zookeeper-master
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] orpiske commented on pull request #10238: CAMEL-19402: test-infra - Reduce the boilerplate code needed
Posted by "orpiske (via GitHub)" <gi...@apache.org>.
orpiske commented on PR #10238:
URL: https://github.com/apache/camel/pull/10238#issuecomment-1568346223
Not right now, but I can re-rerun in about an hour or so ... as soon as my test machine finishes another set of tests. I'll upload them here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] essobedo commented on pull request #10238: CAMEL-19402: test-infra - Reduce the boilerplate code needed
Posted by "essobedo (via GitHub)" <gi...@apache.org>.
essobedo commented on PR #10238:
URL: https://github.com/apache/camel/pull/10238#issuecomment-1570147803
/component-test consul kafka pgevent mongodb redis nats pulsar xmpp zookeeper zookeeper-master
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] orpiske commented on pull request #10238: CAMEL-19402: test-infra - Reduce the boilerplate code needed
Posted by "orpiske (via GitHub)" <gi...@apache.org>.
orpiske commented on PR #10238:
URL: https://github.com/apache/camel/pull/10238#issuecomment-1568058930
> @orpiske WDYT of these small changes in the test-infra code?
Thank you! It definitely needs this cleanup. Big +1 from me.
The GH actions won't automatically test these automatically, though. We'll probably have to run a manual tests for the affected components.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] orpiske commented on pull request #10238: CAMEL-19402: test-infra - Reduce the boilerplate code needed
Posted by "orpiske (via GitHub)" <gi...@apache.org>.
orpiske commented on PR #10238:
URL: https://github.com/apache/camel/pull/10238#issuecomment-1568393333
> That's really weird, I have finally tested all components that you listed above, and they all pass well
Interesting. What even are you using? Are you using x86 or an ARM machine? Some of these tests do not run on arm (i.e.: Apple Silicon).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] github-actions[bot] commented on pull request #10238: CAMEL-19402: test-infra - Reduce the boilerplate code needed
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #10238:
URL: https://github.com/apache/camel/pull/10238#issuecomment-1568139072
:no_entry_sign: There are (likely) no components to be tested in this PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] essobedo commented on pull request #10238: CAMEL-19402: test-infra - Reduce the boilerplate code needed
Posted by "essobedo (via GitHub)" <gi...@apache.org>.
essobedo commented on PR #10238:
URL: https://github.com/apache/camel/pull/10238#issuecomment-1570438442
The failures are not related to those changes so let's merge it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] essobedo commented on pull request #10238: CAMEL-19402: test-infra - Reduce the boilerplate code needed
Posted by "essobedo (via GitHub)" <gi...@apache.org>.
essobedo commented on PR #10238:
URL: https://github.com/apache/camel/pull/10238#issuecomment-1570387376
/component-test consul kafka
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] essobedo commented on pull request #10238: CAMEL-19402: test-infra - Reduce the boilerplate code needed
Posted by "essobedo (via GitHub)" <gi...@apache.org>.
essobedo commented on PR #10238:
URL: https://github.com/apache/camel/pull/10238#issuecomment-1570350910
/component-test consul mongodb nats kafka
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] essobedo commented on pull request #10238: CAMEL-19402: test-infra - Reduce the boilerplate code needed
Posted by "essobedo (via GitHub)" <gi...@apache.org>.
essobedo commented on PR #10238:
URL: https://github.com/apache/camel/pull/10238#issuecomment-1568377902
That's really weird, I have finally tested all components that you listed above, and they all pass well
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] orpiske commented on pull request #10238: CAMEL-19402: test-infra - Reduce the boilerplate code needed
Posted by "orpiske (via GitHub)" <gi...@apache.org>.
orpiske commented on PR #10238:
URL: https://github.com/apache/camel/pull/10238#issuecomment-1568604118
@essobedo My bad. I think it was my environment that was messed up. A full clean build seems to have fixed everything.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] github-actions[bot] commented on pull request #10238: CAMEL-19402: test-infra - Reduce the boilerplate code needed
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #10238:
URL: https://github.com/apache/camel/pull/10238#issuecomment-1568185787
:no_entry_sign: There are (likely) no components to be tested in this PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] essobedo commented on pull request #10238: CAMEL-19402: test-infra - Reduce the boilerplate code needed
Posted by "essobedo (via GitHub)" <gi...@apache.org>.
essobedo commented on PR #10238:
URL: https://github.com/apache/camel/pull/10238#issuecomment-1570153557
/component-test consul kafka pgevent mongodb redis nats pulsar xmpp zookeeper zookeeper-master
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] essobedo merged pull request #10238: CAMEL-19402: test-infra - Reduce the boilerplate code needed
Posted by "essobedo (via GitHub)" <gi...@apache.org>.
essobedo merged PR #10238:
URL: https://github.com/apache/camel/pull/10238
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org