You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@livy.apache.org by GitBox <gi...@apache.org> on 2019/09/17 09:41:38 UTC

[GitHub] [incubator-livy] Jassy1994 commented on a change in pull request #234: [LIVY-683] Livy SQLInterpreter get empty array when extract date format rows to json

Jassy1994 commented on a change in pull request #234: [LIVY-683] Livy SQLInterpreter get empty array when extract date format rows to json
URL: https://github.com/apache/incubator-livy/pull/234#discussion_r325074450
 
 

 ##########
 File path: repl/src/main/scala/org/apache/livy/repl/SQLInterpreter.scala
 ##########
 @@ -91,6 +91,9 @@ class SQLInterpreter(
             // Convert java BigDecimal type to Scala BigDecimal, because current version of
             // Json4s doesn't support java BigDecimal as a primitive type (LIVY-455).
             case i: java.math.BigDecimal => BigDecimal(i)
+            // Convert java.sql.Date type data to String, because java.sql.Date cannot extracted
+            // correctly with Json4s (LIVY-683).
+            case d: java.sql.Date => d.toString
 
 Review comment:
   OK,I will make it

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services