[GitHub] vorburger commented on a change in pull request #468: Fineract-428 Implementing parallelizing and paging of Add accrual accounting

[GitBox <gi...@apache.org>]

vorburger commented on a change in pull request #468: Fineract-428 Implementing parallelizing and paging of Add accrual accounting
URL: https://github.com/apache/fineract/pull/468#discussion_r253858543
 
 

 ##########
 File path: fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/service/LoanReadPlatformService.java
 ##########
 @@ -103,6 +104,8 @@ LoanScheduleData retrieveRepaymentSchedule(Long loanId, RepaymentScheduleRelated
 
     Collection<LoanScheduleAccrualData> retriveScheduleAccrualData();
 
+    List<LoanScheduleAccrualData> retriveScheduleAccrualData(Integer pageSize, Long maxLoanIdInList, String officeHierarchy);
 
 Review comment:
   This looks harmless enough, but of course this will break the build (because `LoanReadPlatformServiceImpl` which `implements LoanReadPlatformService` does not implement this new method), and therefore this PR cannot be merged - hope that makes sense? PS BTW FYI https://issues.apache.org/jira/browse/FINERACT-697

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services