[GitHub] [spark] WeichenXu123 commented on a change in pull request #24354: [SPARK-25348][SQL] Data source for binary files

[GitBox <gi...@apache.org>]

WeichenXu123 commented on a change in pull request #24354: [SPARK-25348][SQL] Data source for binary files
URL: https://github.com/apache/spark/pull/24354#discussion_r274737412
 
 

 ##########
 File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/binaryfile/BinaryFileDataSource.scala
 ##########
 @@ -0,0 +1,48 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *    http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.spark.sql.execution.datasources.binaryfile
+
+import org.apache.spark.sql.types._
+
+/**
+ * `binaryfile` package implements Spark SQL data source API for loading binary file data
+ * as `DataFrame`.
+ *
+ * The loaded `DataFrame` has two columns, the schema is:
+ *  - status: `StructType` (the file status information)
+ *  - content: `BinaryType` (binary data of the file content)
+ *
+ * The schema of "status" column described above is:
+ *  - path: `StringType` (the file path)
+ *  - modification_time: `TimestampType` (last modification time of the file)
+ *  - length: `LongType` (the file length)
+ */
+class BinaryFileDataSource private() {}
+
+object BinaryFileDataSource {
+
+  val fileStatusSchema = StructType(
 
 Review comment:
   make it private instead of inline it. So that code is more clear.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org