You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ossie.apache.org by "Copilot (via GitHub)" <gi...@apache.org> on 2026/09/06 20:21:38 UTC
Re: [PR] Enhance salesforce converter UX [ossie]
Copilot commented on code in PR #286:
URL: https://github.com/apache/ossie/pull/286#discussion_r3945162397
##########
converters/salesforce/src/main/java/org/apache/ossie/app/OssieSalesforceConverter.java:
##########
@@ -39,6 +39,8 @@ public class OssieSalesforceConverter {
public static void main(String[] args) {
if (args.length < 2) {
+ System.err.println("Usage: ossie-salesforce-converter <direction> <input-file>");
+ System.err.println(" direction: toSF | toOSI");
Review Comment:
The usage help advertises `toOSI`, but `parseDirection()` only accepts `toOssie` (case-insensitive). Following the printed usage will currently trigger an "Invalid direction" error; update the usage string to match the supported argument (or add `toOSI` as an accepted alias).
##########
converters/salesforce/README.md:
##########
@@ -232,14 +232,14 @@ dimensions.
## Architecture
```
- ┌───────────────────────┐
- │ OssieSalesforceConverter│
- │ (CLI App) │
- └───────────┬───────────┘
+ ┌──────────────────────────┐
+ │ OssieSalesforceConverter │
+ │ (CLI App) │
+ └───────────┬──────────────┘
│
- ┌───────┴────────┐
+ ┌───────┴─────────┐
Review Comment:
This diagram line has trailing whitespace at the end of the line, which can cause noisy diffs and markdown lint failures; remove the extra spaces.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ossie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org