You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tinkerpop.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2015/11/25 01:57:11 UTC
[jira] [Commented] (TINKERPOP3-990) Mixed types in
VertexPropertyTest
[ https://issues.apache.org/jira/browse/TINKERPOP3-990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15025882#comment-15025882 ]
ASF GitHub Bot commented on TINKERPOP3-990:
-------------------------------------------
GitHub user n-tran opened a pull request:
https://github.com/apache/incubator-tinkerpop/pull/156
TINKERPOP3-990 Removed mixed typing in VertexPropertyTest
Converted integer value to string to maintain type
https://issues.apache.org/jira/browse/TINKERPOP3-990
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/n-tran/incubator-tinkerpop TINKERPOP3-990
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-tinkerpop/pull/156.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #156
----
commit fd95dc8b62c02f73c9de8da31fb7a200efe2929a
Author: Nghia Tran <ng...@gmail.com>
Date: 2015-11-25T00:53:45Z
Removed mixed typing in VertexPropertyTest
Converted integer value to string to maintain type
----
> Mixed types in VertexPropertyTest
> ---------------------------------
>
> Key: TINKERPOP3-990
> URL: https://issues.apache.org/jira/browse/TINKERPOP3-990
> Project: TinkerPop 3
> Issue Type: Bug
> Components: test-suite
> Affects Versions: 3.0.2-incubating
> Reporter: Matthias Broecheler
> Assignee: stephen mallette
> Priority: Minor
> Fix For: 3.1.1-incubating
>
>
> {{shouldRemoveMultiPropertiesWhenVerticesAreRemoved}} of {{VertexPropertyTest.VertexPropertyRemoval}} mixes types. The test uses String data types for "name" but then also adds integers. In systems with a strict typesystem, those integers would get converted to Strings which makes the subsequent removal test fail which checks for integer.class.
> Such mixing of types should be avoided in TinkerPop tests.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)