[GitHub] [arrow] rtpsw commented on a diff in pull request #34392: GH-34391: [C++] Future as-of-join-node hangs on distant times

["rtpsw (via GitHub)" <gi...@apache.org>]

rtpsw commented on code in PR #34392:
URL: https://github.com/apache/arrow/pull/34392#discussion_r1185365697


##########
cpp/src/arrow/acero/asof_join_node.cc:
##########
@@ -200,8 +207,74 @@ class ConcurrentQueue {
   std::condition_variable cond_;
 };
 
+class AsofJoinNode;
+
+#ifndef NDEBUG
+// Get the debug-stream associated with the as-of-join node
+std::ostream* GetDebugStream(AsofJoinNode& node);
+
+// Get the debug-mutex associated with the as-of-join node
+std::mutex* GetDebugMutex(AsofJoinNode& node);
+
+// A debug-facility that wraps output-stream insertions with synchronization. Code like
+//
+//   DebugSync(as_of_join_node) << ... << ... << ... ;
+//
+// will insert to the node's debug-stream and guard all insertions as one operation using
+// the node's debug-mutex.
+class DebugSync {

Review Comment:
   To be sure, you mean that the code here is generally good for pushing and you'd like it refactored soon after?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org