You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2020/05/05 18:52:12 UTC
[GitHub] [incubator-pinot] npawar opened a new pull request #5334: ReturnType in ConstantExecutionNode
npawar opened a new pull request #5334:
URL: https://github.com/apache/incubator-pinot/pull/5334
Setting the returnType in ConstantExecutionNode based on the value, instead of always returning String. This prevents parsing the string to number on every record.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [incubator-pinot] codecov-io edited a comment on pull request #5334: ReturnType in ConstantExecutionNode
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #5334:
URL: https://github.com/apache/incubator-pinot/pull/5334#issuecomment-624267459
# [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/5334?src=pr&el=h1) Report
> Merging [#5334](https://codecov.io/gh/apache/incubator-pinot/pull/5334?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-pinot/commit/2bda544f967e405a6aac20d2bb2abce430da9603&el=desc) will **decrease** coverage by `9.21%`.
> The diff coverage is `29.24%`.
[](https://codecov.io/gh/apache/incubator-pinot/pull/5334?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5334 +/- ##
==========================================
- Coverage 66.08% 56.86% -9.22%
==========================================
Files 1072 1072
Lines 54668 54693 +25
Branches 8152 8158 +6
==========================================
- Hits 36125 31100 -5025
- Misses 15895 21149 +5254
+ Partials 2648 2444 -204
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-pinot/pull/5334?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...roker/requesthandler/BaseBrokerRequestHandler.java](https://codecov.io/gh/apache/incubator-pinot/pull/5334/diff?src=pr&el=tree#diff-cGlub3QtYnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9icm9rZXIvcmVxdWVzdGhhbmRsZXIvQmFzZUJyb2tlclJlcXVlc3RIYW5kbGVyLmphdmE=) | `20.16% <0.00%> (-59.20%)` | :arrow_down: |
| [...core/operator/dociditerators/AndDocIdIterator.java](https://codecov.io/gh/apache/incubator-pinot/pull/5334/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9vcGVyYXRvci9kb2NpZGl0ZXJhdG9ycy9BbmREb2NJZEl0ZXJhdG9yLmphdmE=) | `54.38% <0.00%> (-10.32%)` | :arrow_down: |
| [...or/dociditerators/ExpressionScanDocIdIterator.java](https://codecov.io/gh/apache/incubator-pinot/pull/5334/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9vcGVyYXRvci9kb2NpZGl0ZXJhdG9ycy9FeHByZXNzaW9uU2NhbkRvY0lkSXRlcmF0b3IuamF2YQ==) | `0.00% <0.00%> (-49.70%)` | :arrow_down: |
| [...e/operator/dociditerators/SVScanDocIdIterator.java](https://codecov.io/gh/apache/incubator-pinot/pull/5334/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9vcGVyYXRvci9kb2NpZGl0ZXJhdG9ycy9TVlNjYW5Eb2NJZEl0ZXJhdG9yLmphdmE=) | `49.42% <0.00%> (-20.09%)` | :arrow_down: |
| [...e/operator/dociditerators/MVScanDocIdIterator.java](https://codecov.io/gh/apache/incubator-pinot/pull/5334/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9vcGVyYXRvci9kb2NpZGl0ZXJhdG9ycy9NVlNjYW5Eb2NJZEl0ZXJhdG9yLmphdmE=) | `40.62% <14.28%> (-25.48%)` | :arrow_down: |
| [...he/pinot/core/data/function/DateTimeFunctions.java](https://codecov.io/gh/apache/incubator-pinot/pull/5334/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9kYXRhL2Z1bmN0aW9uL0RhdGVUaW1lRnVuY3Rpb25zLmphdmE=) | `95.23% <100.00%> (-0.77%)` | :arrow_down: |
| [...t/core/data/function/DefaultFunctionEvaluator.java](https://codecov.io/gh/apache/incubator-pinot/pull/5334/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9kYXRhL2Z1bmN0aW9uL0RlZmF1bHRGdW5jdGlvbkV2YWx1YXRvci5qYXZh) | `96.07% <100.00%> (+0.33%)` | :arrow_up: |
| [...che/pinot/core/data/function/FunctionRegistry.java](https://codecov.io/gh/apache/incubator-pinot/pull/5334/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9kYXRhL2Z1bmN0aW9uL0Z1bmN0aW9uUmVnaXN0cnkuamF2YQ==) | `86.27% <100.00%> (ø)` | |
| [...a/org/apache/pinot/minion/metrics/MinionMeter.java](https://codecov.io/gh/apache/incubator-pinot/pull/5334/diff?src=pr&el=tree#diff-cGlub3QtbWluaW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9taW5pb24vbWV0cmljcy9NaW5pb25NZXRlci5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [.../apache/pinot/common/metrics/BrokerQueryPhase.java](https://codecov.io/gh/apache/incubator-pinot/pull/5334/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vbWV0cmljcy9Ccm9rZXJRdWVyeVBoYXNlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [321 more](https://codecov.io/gh/apache/incubator-pinot/pull/5334/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/5334?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/5334?src=pr&el=footer). Last update [0ccb389...6c329b7](https://codecov.io/gh/apache/incubator-pinot/pull/5334?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [incubator-pinot] codecov-io commented on pull request #5334: ReturnType in ConstantExecutionNode
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #5334:
URL: https://github.com/apache/incubator-pinot/pull/5334#issuecomment-624267459
# [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/5334?src=pr&el=h1) Report
> Merging [#5334](https://codecov.io/gh/apache/incubator-pinot/pull/5334?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-pinot/commit/2bda544f967e405a6aac20d2bb2abce430da9603&el=desc) will **decrease** coverage by `21.59%`.
> The diff coverage is `50.94%`.
[](https://codecov.io/gh/apache/incubator-pinot/pull/5334?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5334 +/- ##
===========================================
- Coverage 66.08% 44.48% -21.60%
===========================================
Files 1072 1072
Lines 54668 54693 +25
Branches 8152 8158 +6
===========================================
- Hits 36125 24332 -11793
- Misses 15895 28274 +12379
+ Partials 2648 2087 -561
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-pinot/pull/5334?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...he/pinot/core/data/function/DateTimeFunctions.java](https://codecov.io/gh/apache/incubator-pinot/pull/5334/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9kYXRhL2Z1bmN0aW9uL0RhdGVUaW1lRnVuY3Rpb25zLmphdmE=) | `0.00% <0.00%> (-96.00%)` | :arrow_down: |
| [...t/core/data/function/DefaultFunctionEvaluator.java](https://codecov.io/gh/apache/incubator-pinot/pull/5334/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9kYXRhL2Z1bmN0aW9uL0RlZmF1bHRGdW5jdGlvbkV2YWx1YXRvci5qYXZh) | `0.00% <0.00%> (-95.75%)` | :arrow_down: |
| [...che/pinot/core/data/function/FunctionRegistry.java](https://codecov.io/gh/apache/incubator-pinot/pull/5334/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9kYXRhL2Z1bmN0aW9uL0Z1bmN0aW9uUmVnaXN0cnkuamF2YQ==) | `0.00% <0.00%> (-86.28%)` | :arrow_down: |
| [...e/operator/dociditerators/MVScanDocIdIterator.java](https://codecov.io/gh/apache/incubator-pinot/pull/5334/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9vcGVyYXRvci9kb2NpZGl0ZXJhdG9ycy9NVlNjYW5Eb2NJZEl0ZXJhdG9yLmphdmE=) | `62.50% <14.28%> (-3.61%)` | :arrow_down: |
| [...e/operator/dociditerators/SVScanDocIdIterator.java](https://codecov.io/gh/apache/incubator-pinot/pull/5334/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9vcGVyYXRvci9kb2NpZGl0ZXJhdG9ycy9TVlNjYW5Eb2NJZEl0ZXJhdG9yLmphdmE=) | `68.96% <60.00%> (-0.55%)` | :arrow_down: |
| [...or/dociditerators/ExpressionScanDocIdIterator.java](https://codecov.io/gh/apache/incubator-pinot/pull/5334/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9vcGVyYXRvci9kb2NpZGl0ZXJhdG9ycy9FeHByZXNzaW9uU2NhbkRvY0lkSXRlcmF0b3IuamF2YQ==) | `46.82% <71.05%> (-2.88%)` | :arrow_down: |
| [...core/operator/dociditerators/AndDocIdIterator.java](https://codecov.io/gh/apache/incubator-pinot/pull/5334/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9vcGVyYXRvci9kb2NpZGl0ZXJhdG9ycy9BbmREb2NJZEl0ZXJhdG9yLmphdmE=) | `87.71% <83.33%> (+23.01%)` | :arrow_up: |
| [...roker/requesthandler/BaseBrokerRequestHandler.java](https://codecov.io/gh/apache/incubator-pinot/pull/5334/diff?src=pr&el=tree#diff-cGlub3QtYnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9icm9rZXIvcmVxdWVzdGhhbmRsZXIvQmFzZUJyb2tlclJlcXVlc3RIYW5kbGVyLmphdmE=) | `72.31% <90.00%> (-7.05%)` | :arrow_down: |
| [...ava/org/apache/pinot/spi/data/MetricFieldSpec.java](https://codecov.io/gh/apache/incubator-pinot/pull/5334/diff?src=pr&el=tree#diff-cGlub3Qtc3BpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9zcGkvZGF0YS9NZXRyaWNGaWVsZFNwZWMuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...a/org/apache/pinot/spi/config/table/TableType.java](https://codecov.io/gh/apache/incubator-pinot/pull/5334/diff?src=pr&el=tree#diff-cGlub3Qtc3BpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9zcGkvY29uZmlnL3RhYmxlL1RhYmxlVHlwZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [589 more](https://codecov.io/gh/apache/incubator-pinot/pull/5334/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/5334?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/5334?src=pr&el=footer). Last update [0ccb389...6c329b7](https://codecov.io/gh/apache/incubator-pinot/pull/5334?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org