You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@daffodil.apache.org by GitBox <gi...@apache.org> on 2021/10/27 15:22:45 UTC
[GitHub] [daffodil-vscode] stevedlawrence commented on pull request #44: Improved check on infoset output path
stevedlawrence commented on pull request #44:
URL: https://github.com/apache/daffodil-vscode/pull/44#issuecomment-953038661
To me, the reason to add `Closes #XX` to the commit message rather than just the PR message is more about traceability than auto-closing bugs (though auto-closing is a added benefit). Often we were looking at some old git commit in the git history and want to know which issue led to the creation of that commit. By putting `Closes #XX` in the commit message, it makes that very easy. Without that, you'd probably have to dig around GitHub to find the PR (which isn't always easy for old commits), and then find the `Closes #XX` in the PR message. It's much easier to just have it in the commit. And if it's in the commit message, it will also be in the PR message as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org