You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hbase.apache.org by ap...@apache.org on 2018/09/21 22:53:04 UTC

[2/8] hbase git commit: HBASE-21203 TestZKMainServer#testCommandLineWorks won't pass with default 4lw whitelist

HBASE-21203 TestZKMainServer#testCommandLineWorks won't pass with default 4lw whitelist

Recent versions of ZooKeeper whitelist the so-called 4-letter word admin
commands, and 'stat' is not in the default whitelist. Set system property
zookeeper.4lw.commands.whitelist=* in MiniZooKeeperCluster#setupTestEnv
as we do not need to whitelist 4-letter commands for unit tests.


Project: http://git-wip-us.apache.org/repos/asf/hbase/repo
Commit: http://git-wip-us.apache.org/repos/asf/hbase/commit/6dc9f9e6
Tree: http://git-wip-us.apache.org/repos/asf/hbase/tree/6dc9f9e6
Diff: http://git-wip-us.apache.org/repos/asf/hbase/diff/6dc9f9e6

Branch: refs/heads/branch-2
Commit: 6dc9f9e6da7148724f485f22f8da8549cf297508
Parents: 648d58b
Author: Andrew Purtell <ap...@apache.org>
Authored: Mon Sep 17 14:49:31 2018 -0700
Committer: Andrew Purtell <ap...@apache.org>
Committed: Fri Sep 21 15:37:08 2018 -0700

----------------------------------------------------------------------
 .../org/apache/hadoop/hbase/zookeeper/MiniZooKeeperCluster.java    | 2 ++
 1 file changed, 2 insertions(+)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/hbase/blob/6dc9f9e6/hbase-zookeeper/src/main/java/org/apache/hadoop/hbase/zookeeper/MiniZooKeeperCluster.java
----------------------------------------------------------------------
diff --git a/hbase-zookeeper/src/main/java/org/apache/hadoop/hbase/zookeeper/MiniZooKeeperCluster.java b/hbase-zookeeper/src/main/java/org/apache/hadoop/hbase/zookeeper/MiniZooKeeperCluster.java
index b264563..730d0dd 100644
--- a/hbase-zookeeper/src/main/java/org/apache/hadoop/hbase/zookeeper/MiniZooKeeperCluster.java
+++ b/hbase-zookeeper/src/main/java/org/apache/hadoop/hbase/zookeeper/MiniZooKeeperCluster.java
@@ -176,6 +176,8 @@ public class MiniZooKeeperCluster {
     // set env and directly in order to handle static init/gc issues
     System.setProperty("zookeeper.preAllocSize", "100");
     FileTxnLog.setPreallocSize(100 * 1024);
+    // allow all 4 letter words
+    System.setProperty("zookeeper.4lw.commands.whitelist","*");
   }
 
   public int startup(File baseDir) throws IOException, InterruptedException {