[jira] [Commented] (THRIFT-3149) Make ReadFieldN methods in generated Go code private

["Konstantin Shaposhnikov (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/THRIFT-3149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14543209#comment-14543209 ] 

Konstantin Shaposhnikov commented on THRIFT-3149:
-------------------------------------------------

Pull request to follow soon

> Make ReadFieldN methods in generated Go code private
> ----------------------------------------------------
>
>                 Key: THRIFT-3149
>                 URL: https://issues.apache.org/jira/browse/THRIFT-3149
>             Project: Thrift
>          Issue Type: Improvement
>          Components: Go - Compiler
>    Affects Versions: 0.9.2
>            Reporter: Konstantin Shaposhnikov
>
> The go thrift compiler generates ReadFieldN and writeFieldN methods for every field of a struct. E.g.:
> {code}
> func (p *Statistics) ReadField1(iprot thrift.TProtocol) error {
> ...
> }
> func (p *Statistics) writeField1(oprot thrift.TProtocol) (err error) {
> ...
> }
> {code}
> ReadField1, ReadField2, etc are not very descriptive names and shouldn't be part of public API of a generated package (like writeFieldN).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)