You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "WeichenXu123 (via GitHub)" <gi...@apache.org> on 2025/04/29 09:09:12 UTC
[PR] [draft] Tree training early stop capped by model size [spark]
WeichenXu123 opened a new pull request, #50751:
URL: https://github.com/apache/spark/pull/50751
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error type or message, please read the guideline first in
'common/utils/src/main/resources/error/README.md'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as new features, bug fixes, or other behavior changes. Documentation-only updates are not considered user-facing changes.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
If benchmark tests were added, please run the benchmarks in GitHub Actions for the consistent environment, and the instructions could accord to: https://spark.apache.org/developer-tools.html#github-workflow-benchmarks.
-->
### Was this patch authored or co-authored using generative AI tooling?
<!--
If generative AI tooling has been used in the process of authoring this patch, please include the
phrase: 'Generated-by: ' followed by the name of the tool and its version.
If no, write 'No'.
Please refer to the [ASF Generative Tooling Guidance](https://www.apache.org/legal/generative-tooling.html) for details.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-51974][CONNECT][ML] Limit model size and per-session model cache size [spark]
Posted by "zhengruifeng (via GitHub)" <gi...@apache.org>.
zhengruifeng commented on code in PR #50751:
URL: https://github.com/apache/spark/pull/50751#discussion_r2072807492
##########
sql/connect/server/src/main/scala/org/apache/spark/sql/connect/ml/MLCache.scala:
##########
@@ -61,6 +61,31 @@ private[connect] class MLCache(sessionHolder: SessionHolder) extends Logging {
private[ml] val totalSizeBytes: AtomicLong = new AtomicLong(0)
+ private[ml] val totalModelCacheSizeBytes: AtomicLong = new AtomicLong(0)
+ private[spark] def getModelCacheMaxSize: Long = {
+ sessionHolder.session.conf.get(Connect.CONNECT_SESSION_CONNECT_MODEL_CACHE_MAX_SIZE)
+ }
+ private[spark] def getModelMaxSize: Long = {
+ sessionHolder.session.conf.get(Connect.CONNECT_SESSION_CONNECT_MODEL_MAX_SIZE)
+ }
+
+ def checkModelSize(estimatedModelSize: Long): Unit = {
+ if (totalModelCacheSizeBytes.get() + estimatedModelSize > getModelCacheMaxSize) {
+ throw MLModelCacheSizeOverflowException(
+ "The model cache size in current session is about to exceed" +
+ f"$getModelCacheMaxSize bytes. " +
+ "Please delete existing cached model by executing 'del model' in python client " +
+ "before fitting new model or loading new model, or increase " +
+ "Spark config 'spark.connect.session.connectML.model.maxSize'.")
+ }
+ if (estimatedModelSize > getModelMaxSize) {
+ throw MLModelSizeOverflowException(
+ f"The fitted or loaded model size exceeds $getModelMaxSize bytes. " +
+ f"Please fit or load a model smaller than $getModelMaxSize bytes. " +
+ f"or increase Spark config 'spark.connect.session.connectML.modelCache.maxSize'.")
+ }
Review Comment:
normally we put the formats in the definitions of error classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-51974][CONNECT][ML] Limit model size and per-session model cache size [spark]
Posted by "WeichenXu123 (via GitHub)" <gi...@apache.org>.
WeichenXu123 commented on PR #50751:
URL: https://github.com/apache/spark/pull/50751#issuecomment-2850938710
Refactored configurations: @zhengruifeng @xi-db
* `spark.connect.session.connectML.mlCache.memoryControl.enabled`
* `spark.connect.session.connectML.mlCache.memoryControl.maxInMemorySize`
* `spark.connect.session.connectML.mlCache.memoryControl.offloadingTimeout`
* `spark.connect.session.connectML.mlCache.memoryControl.maxModelSize`
* `spark.connect.session.connectML.mlCache.memoryControl.maxSize`
Only when `spark.connect.session.connectML.mlCache.memoryControl.enabled` is `true`, the rest configures can work.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-51974][CONNECT][ML] Limit model size and per-session model cache size [spark]
Posted by "xi-db (via GitHub)" <gi...@apache.org>.
xi-db commented on code in PR #50751:
URL: https://github.com/apache/spark/pull/50751#discussion_r2071394374
##########
sql/connect/server/src/main/scala/org/apache/spark/sql/connect/ml/MLCache.scala:
##########
@@ -61,6 +61,31 @@ private[connect] class MLCache(sessionHolder: SessionHolder) extends Logging {
private[ml] val totalSizeBytes: AtomicLong = new AtomicLong(0)
+ private[ml] val totalModelCacheSizeBytes: AtomicLong = new AtomicLong(0)
Review Comment:
The "totalSizeBytes" above is tracking the total size in memory. Why do we need to use a different `totalModelCacheSizeBytes`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-51974][CONNECT][ML] Limit model size and per-session model cache size [spark]
Posted by "WeichenXu123 (via GitHub)" <gi...@apache.org>.
WeichenXu123 commented on code in PR #50751:
URL: https://github.com/apache/spark/pull/50751#discussion_r2073371179
##########
sql/connect/server/src/main/scala/org/apache/spark/sql/connect/ml/MLCache.scala:
##########
@@ -61,6 +61,31 @@ private[connect] class MLCache(sessionHolder: SessionHolder) extends Logging {
private[ml] val totalSizeBytes: AtomicLong = new AtomicLong(0)
+ private[ml] val totalModelCacheSizeBytes: AtomicLong = new AtomicLong(0)
Review Comment:
`totalModelCacheSizeBytes ` is for counting in-memory + offloaded data size
`totalSizeBytes` is for counting in-memory size, I will rename it to `totalInMemorySizeBytes`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-51974][CONNECT][ML] Limit model size and per-session model cache size [spark]
Posted by "WeichenXu123 (via GitHub)" <gi...@apache.org>.
WeichenXu123 commented on PR #50751:
URL: https://github.com/apache/spark/pull/50751#issuecomment-2858923291
merged to master
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-51974][CONNECT][ML] Limit model size and per-session model cache size [spark]
Posted by "zhengruifeng (via GitHub)" <gi...@apache.org>.
zhengruifeng commented on PR #50751:
URL: https://github.com/apache/spark/pull/50751#issuecomment-2852798159
LGTM pending CI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-51974][CONNECT][ML] Limit model size and per-session model cache size [spark]
Posted by "zhengruifeng (via GitHub)" <gi...@apache.org>.
zhengruifeng commented on code in PR #50751:
URL: https://github.com/apache/spark/pull/50751#discussion_r2072807807
##########
common/utils/src/main/resources/error/error-conditions.json:
##########
@@ -811,6 +811,16 @@
"Cannot retrieve <objectName> from the ML cache. It is probably because the entry has been evicted."
]
},
+ "MODEL_SIZE_OVERFLOW_EXCEPTION" : {
+ "message" : [
+ "<message>"
Review Comment:
it should contains the main body of the error information:
```
"The model cache size in current session is about to exceed" +
f"$getModelCacheMaxSize bytes. " +
"Please delete existing cached model by executing 'del model' in python client " +
"before fitting new model or loading new model, or increase " +
"Spark config 'spark.connect.session.connectML.model.maxSize'."
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-51974][CONNECT][ML] Limit model size and per-session model cache size [spark]
Posted by "WeichenXu123 (via GitHub)" <gi...@apache.org>.
WeichenXu123 closed pull request #50751: [SPARK-51974][CONNECT][ML] Limit model size and per-session model cache size
URL: https://github.com/apache/spark/pull/50751
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-51974][CONNECT][ML] Limit model size and per-session model cache size [spark]
Posted by "xi-db (via GitHub)" <gi...@apache.org>.
xi-db commented on code in PR #50751:
URL: https://github.com/apache/spark/pull/50751#discussion_r2071390477
##########
sql/connect/server/src/main/scala/org/apache/spark/sql/connect/config/Connect.scala:
##########
@@ -353,4 +353,20 @@ object Connect {
.internal()
.timeConf(TimeUnit.MINUTES)
.createWithDefault(15)
+
+ val CONNECT_SESSION_CONNECT_MODEL_MAX_SIZE =
+ buildConf("spark.connect.session.connectML.model.maxSize")
+ .doc("Maximum size of the SparkML model. The size is in bytes.")
Review Comment:
nit: "the SparkML model" -> "a single SparkML model"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org