You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/02/02 11:01:59 UTC
[GitHub] [apisix-ingress-controller] tokers opened a new pull request #225: chore: group meta info for APISIX resources to Metadata structure
tokers opened a new pull request #225:
URL: https://github.com/apache/apisix-ingress-controller/pull/225
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] codecov-io commented on pull request #225: chore: group meta info for APISIX resources to Metadata structure
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #225:
URL: https://github.com/apache/apisix-ingress-controller/pull/225#issuecomment-771615792
# [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/225?src=pr&el=h1) Report
> Merging [#225](https://codecov.io/gh/apache/apisix-ingress-controller/pull/225?src=pr&el=desc) (6818ff3) into [master](https://codecov.io/gh/apache/apisix-ingress-controller/commit/e1a85f165d16b6d9d2dd78270f2a45c2abf586f0?el=desc) (e1a85f1) will **increase** coverage by `0.10%`.
> The diff coverage is `45.09%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/apisix-ingress-controller/pull/225/graphs/tree.svg?width=650&height=150&src=pr&token=WPLQXPY3V0)](https://codecov.io/gh/apache/apisix-ingress-controller/pull/225?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #225 +/- ##
==========================================
+ Coverage 44.80% 44.90% +0.10%
==========================================
Files 34 33 -1
Lines 2029 2040 +11
==========================================
+ Hits 909 916 +7
- Misses 981 985 +4
Partials 139 139
```
| [Impacted Files](https://codecov.io/gh/apache/apisix-ingress-controller/pull/225?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pkg/ingress/apisix/route.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/225/diff?src=pr&el=tree#diff-cGtnL2luZ3Jlc3MvYXBpc2l4L3JvdXRlLmdv) | `0.00% <0.00%> (ø)` | |
| [pkg/ingress/apisix/service.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/225/diff?src=pr&el=tree#diff-cGtnL2luZ3Jlc3MvYXBpc2l4L3NlcnZpY2UuZ28=) | `0.00% <0.00%> (ø)` | |
| [pkg/apisix/resource.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/225/diff?src=pr&el=tree#diff-cGtnL2FwaXNpeC9yZXNvdXJjZS5nbw==) | `81.31% <100.00%> (+0.85%)` | :arrow_up: |
| [pkg/ingress/apisix/upstream.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/225/diff?src=pr&el=tree#diff-cGtnL2luZ3Jlc3MvYXBpc2l4L3Vwc3RyZWFtLmdv) | `88.37% <100.00%> (+0.56%)` | :arrow_up: |
| [test/e2e/e2e.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/225/diff?src=pr&el=tree#diff-dGVzdC9lMmUvZTJlLmdv) | | |
| [pkg/seven/state/solver.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/225/diff?src=pr&el=tree#diff-cGtnL3NldmVuL3N0YXRlL3NvbHZlci5nbw==) | `3.96% <0.00%> (+1.98%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/225?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/225?src=pr&el=footer). Last update [e1a85f1...6818ff3](https://codecov.io/gh/apache/apisix-ingress-controller/pull/225?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] codecov-io edited a comment on pull request #225: chore: group meta info for APISIX resources to Metadata structure
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #225:
URL: https://github.com/apache/apisix-ingress-controller/pull/225#issuecomment-771615792
# [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/225?src=pr&el=h1) Report
> Merging [#225](https://codecov.io/gh/apache/apisix-ingress-controller/pull/225?src=pr&el=desc) (03b6700) into [master](https://codecov.io/gh/apache/apisix-ingress-controller/commit/fb53d655e8f7c7f74b9d7685ed9e85fdea22c8cc?el=desc) (fb53d65) will **increase** coverage by `0.81%`.
> The diff coverage is `45.09%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/apisix-ingress-controller/pull/225/graphs/tree.svg?width=650&height=150&src=pr&token=WPLQXPY3V0)](https://codecov.io/gh/apache/apisix-ingress-controller/pull/225?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #225 +/- ##
==========================================
+ Coverage 44.57% 45.38% +0.81%
==========================================
Files 33 33
Lines 2035 2047 +12
==========================================
+ Hits 907 929 +22
+ Misses 987 980 -7
+ Partials 141 138 -3
```
| [Impacted Files](https://codecov.io/gh/apache/apisix-ingress-controller/pull/225?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pkg/ingress/apisix/route.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/225/diff?src=pr&el=tree#diff-cGtnL2luZ3Jlc3MvYXBpc2l4L3JvdXRlLmdv) | `0.00% <0.00%> (ø)` | |
| [pkg/ingress/apisix/service.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/225/diff?src=pr&el=tree#diff-cGtnL2luZ3Jlc3MvYXBpc2l4L3NlcnZpY2UuZ28=) | `0.00% <0.00%> (ø)` | |
| [pkg/apisix/resource.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/225/diff?src=pr&el=tree#diff-cGtnL2FwaXNpeC9yZXNvdXJjZS5nbw==) | `81.31% <100.00%> (+0.85%)` | :arrow_up: |
| [pkg/ingress/apisix/upstream.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/225/diff?src=pr&el=tree#diff-cGtnL2luZ3Jlc3MvYXBpc2l4L3Vwc3RyZWFtLmdv) | `74.00% <100.00%> (+1.08%)` | :arrow_up: |
| [pkg/apisix/route.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/225/diff?src=pr&el=tree#diff-cGtnL2FwaXNpeC9yb3V0ZS5nbw==) | `41.72% <0.00%> (+1.98%)` | :arrow_up: |
| [pkg/apisix/cluster.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/225/diff?src=pr&el=tree#diff-cGtnL2FwaXNpeC9jbHVzdGVyLmdv) | `35.07% <0.00%> (+6.16%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/225?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/225?src=pr&el=footer). Last update [fb53d65...03b6700](https://codecov.io/gh/apache/apisix-ingress-controller/pull/225?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] codecov-io commented on pull request #225: chore: group meta info for APISIX resources to Metadata structure
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #225:
URL: https://github.com/apache/apisix-ingress-controller/pull/225#issuecomment-771615792
# [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/225?src=pr&el=h1) Report
> Merging [#225](https://codecov.io/gh/apache/apisix-ingress-controller/pull/225?src=pr&el=desc) (6818ff3) into [master](https://codecov.io/gh/apache/apisix-ingress-controller/commit/e1a85f165d16b6d9d2dd78270f2a45c2abf586f0?el=desc) (e1a85f1) will **increase** coverage by `0.10%`.
> The diff coverage is `45.09%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/apisix-ingress-controller/pull/225/graphs/tree.svg?width=650&height=150&src=pr&token=WPLQXPY3V0)](https://codecov.io/gh/apache/apisix-ingress-controller/pull/225?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #225 +/- ##
==========================================
+ Coverage 44.80% 44.90% +0.10%
==========================================
Files 34 33 -1
Lines 2029 2040 +11
==========================================
+ Hits 909 916 +7
- Misses 981 985 +4
Partials 139 139
```
| [Impacted Files](https://codecov.io/gh/apache/apisix-ingress-controller/pull/225?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pkg/ingress/apisix/route.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/225/diff?src=pr&el=tree#diff-cGtnL2luZ3Jlc3MvYXBpc2l4L3JvdXRlLmdv) | `0.00% <0.00%> (ø)` | |
| [pkg/ingress/apisix/service.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/225/diff?src=pr&el=tree#diff-cGtnL2luZ3Jlc3MvYXBpc2l4L3NlcnZpY2UuZ28=) | `0.00% <0.00%> (ø)` | |
| [pkg/apisix/resource.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/225/diff?src=pr&el=tree#diff-cGtnL2FwaXNpeC9yZXNvdXJjZS5nbw==) | `81.31% <100.00%> (+0.85%)` | :arrow_up: |
| [pkg/ingress/apisix/upstream.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/225/diff?src=pr&el=tree#diff-cGtnL2luZ3Jlc3MvYXBpc2l4L3Vwc3RyZWFtLmdv) | `88.37% <100.00%> (+0.56%)` | :arrow_up: |
| [test/e2e/e2e.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/225/diff?src=pr&el=tree#diff-dGVzdC9lMmUvZTJlLmdv) | | |
| [pkg/seven/state/solver.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/225/diff?src=pr&el=tree#diff-cGtnL3NldmVuL3N0YXRlL3NvbHZlci5nbw==) | `3.96% <0.00%> (+1.98%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/225?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/225?src=pr&el=footer). Last update [e1a85f1...6818ff3](https://codecov.io/gh/apache/apisix-ingress-controller/pull/225?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] tokers merged pull request #225: chore: group meta info for APISIX resources to Metadata structure
Posted by GitBox <gi...@apache.org>.
tokers merged pull request #225:
URL: https://github.com/apache/apisix-ingress-controller/pull/225
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org