You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Michael Park <mp...@apache.org> on 2016/04/03 23:34:34 UTC
Re: Review Request 45314: Updated `network::connect` to use the
typeful `Try` error state.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45314/
-----------------------------------------------------------
(Updated April 3, 2016, 9:34 p.m.)
Review request for mesos, Alex Clemmer and Joris Van Remoortere.
Changes
-------
`s/ConnectError/SocketError/`
Repository: mesos
Description (updated)
-------
Updated `network::connect` to use the typeful `Try` error state.
Diffs (updated)
-----
3rdparty/libprocess/include/process/network.hpp 9976257d2d13316062bc95a22ab564ca0df165e5
3rdparty/libprocess/src/poll_socket.cpp 6e6634b4b352e3723096521843546cf56ec6dd8b
Diff: https://reviews.apache.org/r/45314/diff/
Testing
-------
`make check`
Thanks,
Michael Park
Re: Review Request 45314: Updated `network::connect` to use the typed
error state of `Try` .
Posted by Michael Park <mp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45314/
-----------------------------------------------------------
(Updated April 4, 2016, 8:17 p.m.)
Review request for mesos, Alex Clemmer and Joris Van Remoortere.
Bugs: MESOS-5111
https://issues.apache.org/jira/browse/MESOS-5111
Repository: mesos
Description
-------
See summary.
Diffs
-----
3rdparty/libprocess/include/process/network.hpp 9976257d2d13316062bc95a22ab564ca0df165e5
3rdparty/libprocess/src/poll_socket.cpp 6e6634b4b352e3723096521843546cf56ec6dd8b
Diff: https://reviews.apache.org/r/45314/diff/
Testing
-------
`make check`
Thanks,
Michael Park
Re: Review Request 45314: Updated `network::connect` to use the typed
error state of `Try` .
Posted by Michael Park <mp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45314/
-----------------------------------------------------------
(Updated April 4, 2016, 8:11 p.m.)
Review request for mesos, Alex Clemmer and Joris Van Remoortere.
Summary (updated)
-----------------
Updated `network::connect` to use the typed error state of `Try` .
Repository: mesos
Description (updated)
-------
See summary.
Diffs
-----
3rdparty/libprocess/include/process/network.hpp 9976257d2d13316062bc95a22ab564ca0df165e5
3rdparty/libprocess/src/poll_socket.cpp 6e6634b4b352e3723096521843546cf56ec6dd8b
Diff: https://reviews.apache.org/r/45314/diff/
Testing
-------
`make check`
Thanks,
Michael Park
Re: Review Request 45314: Updated `network::connect` to use the
typeful `Try` error state.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45314/#review126767
-----------------------------------------------------------
Patch looks great!
Reviews applied: [45310, 45311, 45312, 45313, 45314]
Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh
- Mesos ReviewBot
On April 3, 2016, 9:34 p.m., Michael Park wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45314/
> -----------------------------------------------------------
>
> (Updated April 3, 2016, 9:34 p.m.)
>
>
> Review request for mesos, Alex Clemmer and Joris Van Remoortere.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Updated `network::connect` to use the typeful `Try` error state.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/network.hpp 9976257d2d13316062bc95a22ab564ca0df165e5
> 3rdparty/libprocess/src/poll_socket.cpp 6e6634b4b352e3723096521843546cf56ec6dd8b
>
> Diff: https://reviews.apache.org/r/45314/diff/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Michael Park
>
>
Re: Review Request 45314: Updated `network::connect` to use the
typeful `Try` error state.
Posted by Daniel Pravat <dp...@outlook.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45314/#review126799
-----------------------------------------------------------
Ship it!
Ship It!
- Daniel Pravat
On April 3, 2016, 9:34 p.m., Michael Park wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45314/
> -----------------------------------------------------------
>
> (Updated April 3, 2016, 9:34 p.m.)
>
>
> Review request for mesos, Alex Clemmer and Joris Van Remoortere.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Updated `network::connect` to use the typeful `Try` error state.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/network.hpp 9976257d2d13316062bc95a22ab564ca0df165e5
> 3rdparty/libprocess/src/poll_socket.cpp 6e6634b4b352e3723096521843546cf56ec6dd8b
>
> Diff: https://reviews.apache.org/r/45314/diff/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Michael Park
>
>