You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "potiuk (via GitHub)" <gi...@apache.org> on 2023/09/09 20:03:12 UTC

[GitHub] [airflow] potiuk commented on a diff in pull request #34247: Add bandit to pre-commit to detect common security issues

potiuk commented on code in PR #34247:
URL: https://github.com/apache/airflow/pull/34247#discussion_r1320641860


##########
setup.py:
##########
@@ -451,12 +451,7 @@ def write_version(filename: str = str(AIRFLOW_SOURCES_ROOT / "airflow" / "git_ve
     "blinker",
 ]
 
-_devel_only_static_checks = [
-    "pre-commit",
-    "black",
-    "ruff>=0.0.219",
-    "yamllint",
-]
+_devel_only_static_checks = ["pre-commit", "black", "ruff>=0.0.219", "yamllint", "bandit"]

Review Comment:
   Those are tools that are installed in the image. You likely need to add bandit as dependency in the .pre-commit-config.yml as "dependencies" (see other examples).



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org