You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cordova.apache.org by pu...@apache.org on 2013/02/06 02:40:50 UTC

[2/4] git commit: added helpful text so devs know what happened when whitelist exceptions occur

added helpful text so devs know what happened when whitelist exceptions occur


Project: http://git-wip-us.apache.org/repos/asf/cordova-wp8/repo
Commit: http://git-wip-us.apache.org/repos/asf/cordova-wp8/commit/96b1b882
Tree: http://git-wip-us.apache.org/repos/asf/cordova-wp8/tree/96b1b882
Diff: http://git-wip-us.apache.org/repos/asf/cordova-wp8/diff/96b1b882

Branch: refs/heads/master
Commit: 96b1b882a680ede8b28e72f35fd6766fd5d7008c
Parents: 0d9b525
Author: Jesse MacFadyen <pu...@gmail.com>
Authored: Tue Feb 5 15:13:02 2013 -0800
Committer: Jesse MacFadyen <pu...@gmail.com>
Committed: Tue Feb 5 15:13:02 2013 -0800

----------------------------------------------------------------------
 .../standalone/cordovalib/CordovaView.xaml.cs      |    5 +----
 1 files changed, 1 insertions(+), 4 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/cordova-wp8/blob/96b1b882/templates/standalone/cordovalib/CordovaView.xaml.cs
----------------------------------------------------------------------
diff --git a/templates/standalone/cordovalib/CordovaView.xaml.cs b/templates/standalone/cordovalib/CordovaView.xaml.cs
index 0182d2f..44aaf2a 100644
--- a/templates/standalone/cordovalib/CordovaView.xaml.cs
+++ b/templates/standalone/cordovalib/CordovaView.xaml.cs
@@ -401,16 +401,13 @@ namespace WPCordovaClassLib
         {
             if (!configHandler.URLIsAllowed(e.Uri.ToString()))
             {
+                Debug.WriteLine("Whitelist exception: Stopping browser from navigating to :: " + e.Uri.ToString());
                 e.Cancel = true;
                 return;
             }
 
             this.PageDidChange = true;
-            // Debug.WriteLine("GapBrowser_Navigating to :: " + e.Uri.ToString());
             this.nativeExecution.ResetAllCommands();
-
-            // TODO: check whitelist / blacklist
-            // NOTE: Navigation can be cancelled by setting :        e.Cancel = true;
         }
 
         /*