You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by "Hyrum K. Wright" <hy...@mail.utexas.edu> on 2008/07/01 04:31:46 UTC
Re: [PATCH] Expose svn_info_t->depth to JavaHL
Jeremy Whitlock wrote:
> Hi All,
> Attached is a patch that will expose svn_info_t->depth to JavaHL's
> Info2 class. This enhancement will enable me to follow up with
> another patch that will enable JavaHL to check whether a working copy
> path is complete, or not a sparse checkout. (This is something that
> could be used to enhance Subclipse's best practices checks for
> example.) For quick analysis, I have pasted the log message at the
> bottom of this email. Please let me know if there is anything I can
> do to make this patch ready for application.
>
> Take care,
>
> Jeremy
>
> [[[
> Expose the depth member of svn_info_t to JavaHL's Info2 class.
>
> * subversion/bindings/javahl/tests/org/tigris/subversion/javahl/BasicTests.java
> (testBasicInfo2): Updated tests to check depth.
>
> * subversion/bindings/javahl/native/EnumMapper.h
> (mapDepth): New function.
>
> * subversion/bindings/javahl/native/EnumMapper.cpp
> (mapDepth): Implementation.
>
> * subversion/bindings/javahl/native/InfoCallback.cpp
> (createJavaInfo2): Updated to call new depth-aware constructor.
>
> * subversion/bindings/javahl/src/org/tigris/subversion/javahl/Info2.java
> (Info2): Updated constructor for depth argument.
> (getDepth, setDepth): New functions.
> ]]]
Jeremy,
Thanks for the patch. I tweaked the log message just a tad and
committed this in r31936.
I noticed that this patch had the mime-type of application/octet-stream.
That makes it a bit difficult to review inline. Would it be possible
for you to sent future patches as text/x-diff, text/x-patch, or text/plain?
Thanks,
-Hyrum
Re: [PATCH] Expose svn_info_t->depth to JavaHL
Posted by Jeremy Whitlock <jc...@gmail.com>.
> Thanks for the patch. I tweaked the log message just a tad and committed
> this in r31936.
No problem. I hope to help more in the near future.
> I noticed that this patch had the mime-type of application/octet-stream.
> That makes it a bit difficult to review inline. Would it be possible for
> you to sent future patches as text/x-diff, text/x-patch, or text/plain?
Sorry about that. I forget that GMail requires the .txt extension to
fool it into using the proper mime-type. I'll remember next time.
Take care,
Jeremy
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: [PATCH] Expose svn_info_t->depth to JavaHL
Posted by Peter Samuelson <pe...@p12n.org>.
[Mark Phippard]
> Does anyone know how to do that with GMail? I have never figured it
> out, and it always uses application/octet-stream when I attach a
> patch.
I don't use gmail, but you can fool a lot of MUAs by naming your
attachment to end in ".txt".
--
Peter Samuelson | org-tld!p12n!peter | http://p12n.org/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: [PATCH] Expose svn_info_t->depth to JavaHL
Posted by Senthil Kumaran S <se...@collab.net>.
Mark Phippard wrote:
>> I noticed that this patch had the mime-type of application/octet-stream.
>> That makes it a bit difficult to review inline. Would it be possible for
>> you to sent future patches as text/x-diff, text/x-patch, or text/plain?
>
> Does anyone know how to do that with GMail? I have never figured it
> out, and it always uses application/octet-stream when I attach a
> patch.
Gmail with some mail client like thunderbird should do the trick I guess.
My .2 cents.
--
Senthil Kumaran S
http://www.stylesen.org/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: [PATCH] Expose svn_info_t->depth to JavaHL
Posted by Mark Phippard <ma...@gmail.com>.
On Tue, Jul 1, 2008 at 12:31 AM, Hyrum K. Wright
<hy...@mail.utexas.edu> wrote:
> Jeremy Whitlock wrote:
>>
>> Hi All,
>> Attached is a patch that will expose svn_info_t->depth to JavaHL's
>> Info2 class. This enhancement will enable me to follow up with
>> another patch that will enable JavaHL to check whether a working copy
>> path is complete, or not a sparse checkout. (This is something that
>> could be used to enhance Subclipse's best practices checks for
>> example.) For quick analysis, I have pasted the log message at the
>> bottom of this email. Please let me know if there is anything I can
>> do to make this patch ready for application.
>>
>> Take care,
>>
>> Jeremy
>>
>> [[[
>> Expose the depth member of svn_info_t to JavaHL's Info2 class.
>>
>> *
>> subversion/bindings/javahl/tests/org/tigris/subversion/javahl/BasicTests.java
>> (testBasicInfo2): Updated tests to check depth.
>>
>> * subversion/bindings/javahl/native/EnumMapper.h
>> (mapDepth): New function.
>>
>> * subversion/bindings/javahl/native/EnumMapper.cpp
>> (mapDepth): Implementation.
>>
>> * subversion/bindings/javahl/native/InfoCallback.cpp
>> (createJavaInfo2): Updated to call new depth-aware constructor.
>>
>> * subversion/bindings/javahl/src/org/tigris/subversion/javahl/Info2.java
>> (Info2): Updated constructor for depth argument.
>> (getDepth, setDepth): New functions.
>> ]]]
>
> Jeremy,
> Thanks for the patch. I tweaked the log message just a tad and committed
> this in r31936.
>
> I noticed that this patch had the mime-type of application/octet-stream.
> That makes it a bit difficult to review inline. Would it be possible for
> you to sent future patches as text/x-diff, text/x-patch, or text/plain?
Does anyone know how to do that with GMail? I have never figured it
out, and it always uses application/octet-stream when I attach a
patch.
--
Thanks
Mark Phippard
http://markphip.blogspot.com/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org