You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2023/01/12 17:04:12 UTC

[GitHub] [arrow] js8544 commented on pull request #15291: GH-15290: [C++][Compute] Optimize IfElse kernel AAS/ASA case when the scalar is null

js8544 commented on PR #15291:
URL: https://github.com/apache/arrow/pull/15291#issuecomment-1380731034

   > It looks like CheckWithDifferentShapes in scalar_if_else_test.cc should hit all these new branches. Have you confirmed?
   
   Yep. CheckWithDifferentShapes will first check the input AAA case. And then enumerate all cases with Scalars, making sure the result is the same as when broadcasting the Scalar to an Array.  Also there were bugs in my initial implementation and it correctly failed.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org