[GitHub] [spark] viirya commented on a change in pull request #24464: [SPARK-27439][SQL] Use existing queryexecution in explaining Dataset

[GitBox <gi...@apache.org>]

viirya commented on a change in pull request #24464: [SPARK-27439][SQL] Use existing queryexecution in explaining Dataset
URL: https://github.com/apache/spark/pull/24464#discussion_r278886589
 
 

 ##########
 File path: sql/core/src/main/scala/org/apache/spark/sql/execution/command/commands.scala
 ##########
 @@ -138,20 +138,23 @@ case class DataWritingCommandExec(cmd: DataWritingCommand, child: SparkPlan)
  * @param extended whether to do extended explain or not
  * @param codegen whether to output generated code from whole-stage codegen or not
  * @param cost whether to show cost information for operators.
+ * @param optQueryExecution if present, this command uses pre-analyzed plan of it,
+ *                          instead of re-analyzing plan.
  */
 case class ExplainCommand(
     logicalPlan: LogicalPlan,
     extended: Boolean = false,
     codegen: Boolean = false,
-    cost: Boolean = false)
+    cost: Boolean = false,
+    optQueryExecution: Option[QueryExecution] = None)
 
 Review comment:
   I don't have a better way to keep using analyzed plan of dataset and showing correct pre-analyzed plan, other than passing in the query execution of the dataset.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org