You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@samza.apache.org by Jakob Homan <jg...@apache.org> on 2014/05/01 23:33:18 UTC

Re: Review Request 20697: SAMZA-151

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20697/#review41956
-----------------------------------------------------------

Ship it!


Ship It!

- Jakob Homan


On April 25, 2014, 2:27 p.m., Yan Fang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20697/
> -----------------------------------------------------------
> 
> (Updated April 25, 2014, 2:27 p.m.)
> 
> 
> Review request for samza.
> 
> 
> Repository: samza
> 
> 
> Description
> -------
> 
> Fail early when a consumer is misconfigured.
> 
> 1. wraped the consumer register with try and catch
> 2. added SystemConsumerException extends SamzaException
> 3. added test for checking throwing the correct exception
> 
> 
> Diffs
> -----
> 
>   samza-core/src/main/scala/org/apache/samza/system/SystemConsumers.scala 7624aef 
>   samza-core/src/test/scala/org/apache/samza/system/TestSystemConsumers.scala e1b211d 
> 
> Diff: https://reviews.apache.org/r/20697/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Yan Fang
> 
>