You are viewing a plain text version of this content. The canonical link for it is here.
Posted to mapreduce-issues@hadoop.apache.org by "Rodrigo Schmidt (JIRA)" <ji...@apache.org> on 2010/02/14 10:45:27 UTC

[jira] Created: (MAPREDUCE-1492) Delete or recreate obsolete har files used on hdfs raid

Delete or recreate obsolete har files used on hdfs raid
-------------------------------------------------------

                 Key: MAPREDUCE-1492
                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-1492
             Project: Hadoop Map/Reduce
          Issue Type: Improvement
          Components: contrib/raid
            Reporter: Rodrigo Schmidt
            Assignee: Rodrigo Schmidt


The current code for har on raid doesn't delete or recreate har directories when they become obsolete. We should fix that.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (MAPREDUCE-1492) Delete or recreate obsolete har files used on hdfs raid

Posted by "Rodrigo Schmidt (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MAPREDUCE-1492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12879073#action_12879073 ] 

Rodrigo Schmidt commented on MAPREDUCE-1492:
--------------------------------------------

Thanks Ram!

> Delete or recreate obsolete har files used on hdfs raid
> -------------------------------------------------------
>
>                 Key: MAPREDUCE-1492
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-1492
>             Project: Hadoop Map/Reduce
>          Issue Type: Improvement
>          Components: contrib/raid
>            Reporter: Rodrigo Schmidt
>            Assignee: Rodrigo Schmidt
>         Attachments: MAPREDUCE-1492.0.patch
>
>
> The current code for har on raid doesn't delete or recreate har directories when they become obsolete. We should fix that.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (MAPREDUCE-1492) Delete or recreate obsolete har files used on hdfs raid

Posted by "Rodrigo Schmidt (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/MAPREDUCE-1492?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Rodrigo Schmidt updated MAPREDUCE-1492:
---------------------------------------

    Status: Patch Available  (was: Open)

> Delete or recreate obsolete har files used on hdfs raid
> -------------------------------------------------------
>
>                 Key: MAPREDUCE-1492
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-1492
>             Project: Hadoop Map/Reduce
>          Issue Type: Improvement
>          Components: contrib/raid
>            Reporter: Rodrigo Schmidt
>            Assignee: Rodrigo Schmidt
>         Attachments: MAPREDUCE-1492.0.patch
>
>
> The current code for har on raid doesn't delete or recreate har directories when they become obsolete. We should fix that.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (MAPREDUCE-1492) Delete or recreate obsolete har files used on hdfs raid

Posted by "dhruba borthakur (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/MAPREDUCE-1492?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

dhruba borthakur updated MAPREDUCE-1492:
----------------------------------------

           Status: Resolved  (was: Patch Available)
     Hadoop Flags: [Reviewed]
    Fix Version/s: 0.22.0
       Resolution: Fixed

I just committed this. Thanks Rodrigo!

> Delete or recreate obsolete har files used on hdfs raid
> -------------------------------------------------------
>
>                 Key: MAPREDUCE-1492
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-1492
>             Project: Hadoop Map/Reduce
>          Issue Type: Improvement
>          Components: contrib/raid
>            Reporter: Rodrigo Schmidt
>            Assignee: Rodrigo Schmidt
>             Fix For: 0.22.0
>
>         Attachments: MAPREDUCE-1492.0.patch
>
>
> The current code for har on raid doesn't delete or recreate har directories when they become obsolete. We should fix that.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (MAPREDUCE-1492) Delete or recreate obsolete har files used on hdfs raid

Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MAPREDUCE-1492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12878387#action_12878387 ] 

Hadoop QA commented on MAPREDUCE-1492:
--------------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12446977/MAPREDUCE-1492.0.patch
  against trunk revision 953976.

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 7 new or modified tests.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    -1 core tests.  The patch failed core unit tests.

    -1 contrib tests.  The patch failed contrib unit tests.

Test results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h4.grid.sp2.yahoo.net/240/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h4.grid.sp2.yahoo.net/240/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h4.grid.sp2.yahoo.net/240/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h4.grid.sp2.yahoo.net/240/console

This message is automatically generated.

> Delete or recreate obsolete har files used on hdfs raid
> -------------------------------------------------------
>
>                 Key: MAPREDUCE-1492
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-1492
>             Project: Hadoop Map/Reduce
>          Issue Type: Improvement
>          Components: contrib/raid
>            Reporter: Rodrigo Schmidt
>            Assignee: Rodrigo Schmidt
>         Attachments: MAPREDUCE-1492.0.patch
>
>
> The current code for har on raid doesn't delete or recreate har directories when they become obsolete. We should fix that.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (MAPREDUCE-1492) Delete or recreate obsolete har files used on hdfs raid

Posted by "Ramkumar Vadali (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MAPREDUCE-1492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12879044#action_12879044 ] 

Ramkumar Vadali commented on MAPREDUCE-1492:
--------------------------------------------

+1
Source and unit-test changes look good.

> Delete or recreate obsolete har files used on hdfs raid
> -------------------------------------------------------
>
>                 Key: MAPREDUCE-1492
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-1492
>             Project: Hadoop Map/Reduce
>          Issue Type: Improvement
>          Components: contrib/raid
>            Reporter: Rodrigo Schmidt
>            Assignee: Rodrigo Schmidt
>         Attachments: MAPREDUCE-1492.0.patch
>
>
> The current code for har on raid doesn't delete or recreate har directories when they become obsolete. We should fix that.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (MAPREDUCE-1492) Delete or recreate obsolete har files used on hdfs raid

Posted by "Rodrigo Schmidt (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MAPREDUCE-1492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12878431#action_12878431 ] 

Rodrigo Schmidt commented on MAPREDUCE-1492:
--------------------------------------------

It doesn't look like my patch could have caused all these core test errors.

As for the contrib tests, I couldn't find which ones actually failed. I tested the contrib/raid ones on my computer and they work fine for me. I guess it's something related to trunk being broken.



> Delete or recreate obsolete har files used on hdfs raid
> -------------------------------------------------------
>
>                 Key: MAPREDUCE-1492
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-1492
>             Project: Hadoop Map/Reduce
>          Issue Type: Improvement
>          Components: contrib/raid
>            Reporter: Rodrigo Schmidt
>            Assignee: Rodrigo Schmidt
>         Attachments: MAPREDUCE-1492.0.patch
>
>
> The current code for har on raid doesn't delete or recreate har directories when they become obsolete. We should fix that.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (MAPREDUCE-1492) Delete or recreate obsolete har files used on hdfs raid

Posted by "Rodrigo Schmidt (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/MAPREDUCE-1492?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Rodrigo Schmidt updated MAPREDUCE-1492:
---------------------------------------

    Attachment: MAPREDUCE-1492.0.patch

This patch deletes har directories if the parent directory has been deleted.

It's not a complete check for obsolete hars, but it's simple and better than not doing anything.

> Delete or recreate obsolete har files used on hdfs raid
> -------------------------------------------------------
>
>                 Key: MAPREDUCE-1492
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-1492
>             Project: Hadoop Map/Reduce
>          Issue Type: Improvement
>          Components: contrib/raid
>            Reporter: Rodrigo Schmidt
>            Assignee: Rodrigo Schmidt
>         Attachments: MAPREDUCE-1492.0.patch
>
>
> The current code for har on raid doesn't delete or recreate har directories when they become obsolete. We should fix that.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.