You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2024/05/22 05:57:05 UTC

[kudu-CR] Fix row project codegen params noalias overflow

Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/19952 )

Change subject: Fix row_project codegen params noalias overflow
......................................................................


Patch Set 4: Code-Review+2

Thanks a lot for the patch!

I was cleaning up my mailbox and found an email about this patch.  It's been almost a year!  I'm not sure how I missed this.  :)

Indeed: the newly addParamAttr() uses 0-based indices once it has been introduced in LLVM 5.0.0 with [1] in March 2017.

[1] https://github.com/llvm/llvm-project/commit/a0b45f4bfccb3ab197ca504032c28160ce82eac2


-- 
To view, visit http://gerrit.cloudera.org:8080/19952
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1dab7d46cff96ed1ebbd020584a066f04e6ca12a
Gerrit-Change-Number: 19952
Gerrit-PatchSet: 4
Gerrit-Owner: Anonymous Coward <sq...@sqh.me>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Comment-Date: Wed, 22 May 2024 05:57:05 +0000
Gerrit-HasComments: No