You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2020/08/10 08:57:54 UTC
[GitHub] [incubator-dolphinscheduler] codecov-commenter commented on pull request #3385: [Improvement][dao,server] unit test for ConditionsTask
codecov-commenter commented on pull request #3385:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/3385#issuecomment-671239301
# [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/3385?src=pr&el=h1) Report
> Merging [#3385](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/3385?src=pr&el=desc) into [dev](https://codecov.io/gh/apache/incubator-dolphinscheduler/commit/5584f0cb4d27e3ae64ec28c65a8669b38c75d188&el=desc) will **increase** coverage by `0.29%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/3385?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## dev #3385 +/- ##
============================================
+ Coverage 35.60% 35.90% +0.29%
- Complexity 2569 2587 +18
============================================
Files 448 448
Lines 20919 20919
Branches 2558 2559 +1
============================================
+ Hits 7448 7510 +62
+ Misses 12785 12721 -64
- Partials 686 688 +2
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/3385?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ache/dolphinscheduler/dao/entity/TaskInstance.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/3385/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1kYW8vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvZGFvL2VudGl0eS9UYXNrSW5zdGFuY2UuamF2YQ==) | `68.06% <100.00%> (+7.56%)` | `55.00 <4.00> (+7.00)` | |
| [...he/dolphinscheduler/common/thread/ThreadUtils.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/3385/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL3RocmVhZC9UaHJlYWRVdGlscy5qYXZh) | `66.15% <0.00%> (-3.08%)` | `13.00% <0.00%> (-1.00%)` | |
| [...server/master/runner/MasterBaseTaskExecThread.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/3385/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL21hc3Rlci9ydW5uZXIvTWFzdGVyQmFzZVRhc2tFeGVjVGhyZWFkLmphdmE=) | `38.27% <0.00%> (+1.23%)` | `7.00% <0.00%> (+1.00%)` | |
| [...server/master/runner/ConditionsTaskExecThread.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/3385/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL21hc3Rlci9ydW5uZXIvQ29uZGl0aW9uc1Rhc2tFeGVjVGhyZWFkLmphdmE=) | `87.09% <0.00%> (+87.09%)` | `11.00% <0.00%> (+11.00%)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/3385?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/3385?src=pr&el=footer). Last update [5584f0c...d4b61ed](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/3385?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org