You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "unbridled-41 (via GitHub)" <gi...@apache.org> on 2026/08/29 17:11:22 UTC

[I] [Bug] Transactional message escape retry uses 2 ^ n (XOR) instead of exponential backoff, including a zero-delay retry [rocketmq]

unbridled-41 opened a new issue, #10989:
URL: https://github.com/apache/rocketmq/issues/10989

   ### Before Creating the Bug Report
   
   - [x] I found a bug, not just asking a question, which should be created in [GitHub Discussions](https://github.com/apache/rocketmq/discussions).
   - [x] I have searched the [GitHub Issues](https://github.com/apache/rocketmq/issues) and [GitHub Discussions](https://github.com/apache/rocketmq/discussions) of this repository and believe this is not a duplicate.
   - [x] I have confirmed that this bug belongs to the current repository, not other repositories of RocketMQ.
   
   ### Runtime platform environment
   
   - OS: Linux
   - Component: Broker (`TransactionalMessageServiceImpl`)
   
   ### RocketMQ version
   
   - branch: develop
   - Git commit id: e348efa66
   
   ### JDK Version
   
   JDK 8
   
   ### Describe the Bug
   
   In `TransactionalMessageServiceImpl#check`, when a broker configured with `enableSlaveActingMaster` fails to escape a transactional half message, the retry delay is computed with the XOR operator instead of exponentiation:
   
   ```java
   if (escapeFailCnt < MAX_RETRY_TIMES_FOR_ESCAPE) {
       escapeFailCnt++;
       Thread.sleep(100L * (2 ^ escapeFailCnt));   // '^' is XOR in Java, not power
   }
   ```
   
   The actual sleep sequence for `escapeFailCnt` = 1..10 is `300, 0, 100, 600, 700, 400, 500, 800, 900, 200` ms instead of the intended exponential `200, 400, 800, ...`. In particular the second consecutive failure sleeps **0 ms**, so the check loop immediately hammers the store with another full put attempt, defeating the purpose of the backoff (this code was introduced with the escaping feature in #5012 / ISSUE #5012).
   
   ### Steps to Reproduce
   
   `Thread.sleep(100L * (2 ^ 2))` evaluates to `sleep(0)` because `2 ^ 2 == 0`. Print `100L * (2 ^ n)` for n = 1..10 to see the non-monotonic sequence.
   
   ### What Did You Expect to See?
   
   An exponential backoff between escape retries: `100L * (1 << escapeFailCnt)` ms, i.e. 200, 400, 800, ... ms.
   
   ### What Did You See Instead?
   
   A non-monotonic sequence produced by XOR, including a 0 ms delay, so failed escape attempts are retried without any backoff.
   
   ### Additional Context
   
   I extracted the computation into a small package-private helper so the backoff sequence is unit-testable, and will submit a PR with the test.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] [Bug] Transactional message escape retry uses 2 ^ n (XOR) instead of exponential backoff, including a zero-delay retry [rocketmq]

Posted by "RockteMQ-AI (via GitHub)" <gi...@apache.org>.
RockteMQ-AI commented on issue #10989:
URL: https://github.com/apache/rocketmq/issues/10989#issuecomment-5464032172

   **Issue Evaluation**
   
   Category: `bug` | Status: **Needs Verification**
   
   This issue reports a bug. Automated verification is required to confirm the root cause and impact.
   
   **Next Steps:**
   - Code engine will analyze the reported code path
   - Verify if the issue is reproducible in the current codebase
   - Assess severity and impact
   
   ---
   *Automated evaluation by RockteMQ-AI*


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org