[GitHub] [superset] michael-s-molina commented on pull request #19257: fix(sql lab): table selector should display all the selected tables

[GitBox <gi...@apache.org>]

michael-s-molina commented on pull request #19257:
URL: https://github.com/apache/superset/pull/19257#issuecomment-1080515797


   @diegomedina248 Thanks for addressing the suggestions. 
   
   The default behavior of the multi-select component is to keep the popup open while the user is doing the selections. In this PR, if I'm trying to select multiple tables, it's really annoying because every selection closes the popup. Is it possible to keep it open?
   
   It would be nice to set `allowClear` to the multiple select version as well.
   
   The changes to the TableSelector affected other modules. The dataset editor is not showing the selected table anymore.
   
   https://user-images.githubusercontent.com/70410625/160385060-1992e519-83c8-4462-92dd-d2dd4f56b50e.mov
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org