You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "David Ribeiro Alves (Code Review)" <ge...@cloudera.org> on 2017/03/08 20:28:48 UTC
[kudu-CR] [flaky tests] Address LSAN false positives
David Ribeiro Alves has uploaded a new change for review.
http://gerrit.cloudera.org:8080/6320
Change subject: [flaky tests] Address LSAN false positives
......................................................................
[flaky tests] Address LSAN false positives
Some tests, like external_mini_cluster-itest, are now only failing
in ASAN due to leaks. Upon inspection I could only find false
positives among these leaks around thread local variables.
This seems related to this issue:
https://github.com/google/sanitizers/issues/757
The fix is to wrap those specific instances of false positives
with ScopedLeakDisabler so that they don't get reported.
Change-Id: I8c8d9ff83c0cfbc11cab213a25cbd5daa3b25869
---
M src/kudu/util/kernel_stack_watchdog.cc
M src/kudu/util/striped64.cc
M src/kudu/util/thread_restrictions.cc
3 files changed, 15 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/20/6320/1
--
To view, visit http://gerrit.cloudera.org:8080/6320
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I8c8d9ff83c0cfbc11cab213a25cbd5daa3b25869
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves <dr...@apache.org>
[kudu-CR] [flaky tests] Address LSAN false positives
Posted by "David Ribeiro Alves (Code Review)" <ge...@cloudera.org>.
David Ribeiro Alves has uploaded a new patch set (#2).
Change subject: [flaky tests] Address LSAN false positives
......................................................................
[flaky tests] Address LSAN false positives
Some tests, like external_mini_cluster-itest, are now only failing
in ASAN due to leaks. Upon inspection I could only find false
positives among these leaks around thread local variables.
This seems related to this issue:
https://github.com/google/sanitizers/issues/757
The fix is to wrap those specific instances of false positives
with ScopedLeakDisabler so that they don't get reported.
Change-Id: I8c8d9ff83c0cfbc11cab213a25cbd5daa3b25869
---
M src/kudu/util/kernel_stack_watchdog.cc
M src/kudu/util/striped64.cc
M src/kudu/util/thread_restrictions.cc
3 files changed, 15 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/20/6320/2
--
To view, visit http://gerrit.cloudera.org:8080/6320
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I8c8d9ff83c0cfbc11cab213a25cbd5daa3b25869
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] [flaky tests] Address LSAN false positives
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change.
Change subject: [flaky tests] Address LSAN false positives
......................................................................
Patch Set 2:
Not sure if it will be actively developed with in the future or not, but should we also note this in threadlocal.h?
--
To view, visit http://gerrit.cloudera.org:8080/6320
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8c8d9ff83c0cfbc11cab213a25cbd5daa3b25869
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No
[kudu-CR] [flaky tests] Address LSAN false positives
Posted by "David Ribeiro Alves (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/6320
to look at the new patch set (#3).
Change subject: [flaky tests] Address LSAN false positives
......................................................................
[flaky tests] Address LSAN false positives
Some tests, like external_mini_cluster-itest, are now only failing
in ASAN due to leaks. Upon inspection I could only find false
positives among these leaks around thread local variables.
This seems related to this issue:
https://github.com/google/sanitizers/issues/757
The fix is to wrap those specific instances of false positives
with ScopedLeakDisabler so that they don't get reported.
After many tries I was unable to come up with the right incantation
to cause this in dist-tests. Running the highest failing test in
ASAN with stress was not enough to cause this. Somehow this is
more likely in jenkins where these failures are pretty common.
Change-Id: I8c8d9ff83c0cfbc11cab213a25cbd5daa3b25869
---
M src/kudu/util/kernel_stack_watchdog.cc
M src/kudu/util/striped64.cc
M src/kudu/util/thread_restrictions.cc
3 files changed, 15 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/20/6320/3
--
To view, visit http://gerrit.cloudera.org:8080/6320
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I8c8d9ff83c0cfbc11cab213a25cbd5daa3b25869
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves <da...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] [flaky tests] Address LSAN false positives
Posted by "David Ribeiro Alves (Code Review)" <ge...@cloudera.org>.
David Ribeiro Alves has posted comments on this change.
Change subject: [flaky tests] Address LSAN false positives
......................................................................
Patch Set 3:
As stated in the commit message I couldn't repro this on dist-test after many tries. Still think that this is worth merging since this failure is still pretty common
--
To view, visit http://gerrit.cloudera.org:8080/6320
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8c8d9ff83c0cfbc11cab213a25cbd5daa3b25869
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves <da...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <da...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No
[kudu-CR] [flaky tests] Address LSAN false positives
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change.
Change subject: [flaky tests] Address LSAN false positives
......................................................................
Patch Set 3: Code-Review+2
(1 comment)
http://gerrit.cloudera.org:8080/#/c/6320/3/src/kudu/util/striped64.cc
File src/kudu/util/striped64.cc:
Line 144: INIT_STATIC_THREAD_LOCAL(HashCode, hashcode_);
I just removed this yesterday, looks like you'll need a rebase
--
To view, visit http://gerrit.cloudera.org:8080/6320
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8c8d9ff83c0cfbc11cab213a25cbd5daa3b25869
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves <da...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <da...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes
[kudu-CR] [flaky tests] Address LSAN false positives
Posted by "David Ribeiro Alves (Code Review)" <ge...@cloudera.org>.
David Ribeiro Alves has posted comments on this change.
Change subject: [flaky tests] Address LSAN false positives
......................................................................
Patch Set 3:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/6320/3/src/kudu/util/striped64.cc
File src/kudu/util/striped64.cc:
Line 144: INIT_STATIC_THREAD_LOCAL(HashCode, hashcode_);
> I just removed this yesterday, looks like you'll need a rebase
Done
--
To view, visit http://gerrit.cloudera.org:8080/6320
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8c8d9ff83c0cfbc11cab213a25cbd5daa3b25869
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves <da...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <da...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes
[kudu-CR] [flaky tests] Address LSAN false positives
Posted by "David Ribeiro Alves (Code Review)" <ge...@cloudera.org>.
David Ribeiro Alves has posted comments on this change.
Change subject: [flaky tests] Address LSAN false positives
......................................................................
Patch Set 4: Code-Review+2
just rebased, keeping the +2
--
To view, visit http://gerrit.cloudera.org:8080/6320
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8c8d9ff83c0cfbc11cab213a25cbd5daa3b25869
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves <da...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <da...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No
[kudu-CR] [flaky tests] Address LSAN false positives
Posted by "David Ribeiro Alves (Code Review)" <ge...@cloudera.org>.
David Ribeiro Alves has submitted this change and it was merged.
Change subject: [flaky tests] Address LSAN false positives
......................................................................
[flaky tests] Address LSAN false positives
Some tests, like external_mini_cluster-itest, are now only failing
in ASAN due to leaks. Upon inspection I could only find false
positives among these leaks around thread local variables.
This seems related to this issue:
https://github.com/google/sanitizers/issues/757
The fix is to wrap those specific instances of false positives
with ScopedLeakDisabler so that they don't get reported.
After many tries I was unable to come up with the right incantation
to cause this in dist-tests. Running the highest failing test in
ASAN with stress was not enough to cause this. Somehow this is
more likely in jenkins where these failures are pretty common.
Change-Id: I8c8d9ff83c0cfbc11cab213a25cbd5daa3b25869
Reviewed-on: http://gerrit.cloudera.org:8080/6320
Reviewed-by: David Ribeiro Alves <da...@gmail.com>
Tested-by: Kudu Jenkins
---
M src/kudu/util/kernel_stack_watchdog.cc
M src/kudu/util/thread_restrictions.cc
2 files changed, 8 insertions(+), 0 deletions(-)
Approvals:
David Ribeiro Alves: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/6320
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8c8d9ff83c0cfbc11cab213a25cbd5daa3b25869
Gerrit-PatchSet: 5
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves <da...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <da...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] [flaky tests] Address LSAN false positives
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change.
Change subject: [flaky tests] Address LSAN false positives
......................................................................
Patch Set 2:
have you been able to repro this with dist-test? From the github issue the LSAN people seem to have reproed even taking TLS out of the equation. Would be good to have confirmation that these annotations fix the issue we're seeing (as opposed to us doing a few retries)
--
To view, visit http://gerrit.cloudera.org:8080/6320
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8c8d9ff83c0cfbc11cab213a25cbd5daa3b25869
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No
[kudu-CR] [flaky tests] Address LSAN false positives
Posted by "David Ribeiro Alves (Code Review)" <ge...@cloudera.org>.
Hello Todd Lipcon, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/6320
to look at the new patch set (#4).
Change subject: [flaky tests] Address LSAN false positives
......................................................................
[flaky tests] Address LSAN false positives
Some tests, like external_mini_cluster-itest, are now only failing
in ASAN due to leaks. Upon inspection I could only find false
positives among these leaks around thread local variables.
This seems related to this issue:
https://github.com/google/sanitizers/issues/757
The fix is to wrap those specific instances of false positives
with ScopedLeakDisabler so that they don't get reported.
After many tries I was unable to come up with the right incantation
to cause this in dist-tests. Running the highest failing test in
ASAN with stress was not enough to cause this. Somehow this is
more likely in jenkins where these failures are pretty common.
Change-Id: I8c8d9ff83c0cfbc11cab213a25cbd5daa3b25869
---
M src/kudu/util/kernel_stack_watchdog.cc
M src/kudu/util/thread_restrictions.cc
2 files changed, 8 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/20/6320/4
--
To view, visit http://gerrit.cloudera.org:8080/6320
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I8c8d9ff83c0cfbc11cab213a25cbd5daa3b25869
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves <da...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <da...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>