You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@bloodhound.apache.org by Apache Bloodhound <bl...@incubator.apache.org> on 2012/06/24 00:59:56 UTC
[Apache Bloodhound] #108: Prevent changing product prefix
#108: Prevent changing product prefix
----------------------------------------+----------------------------------
Reporter: olemis | Owner: nobody
Type: defect | Status: new
Priority: critical | Milestone: RC1 for initial
Component: multiproduct | release
Keywords: db relationships integrity | Version:
----------------------------------------+----------------------------------
Product prefix should be considered as an immutable identifier set once at
product creation time . It must not be changed ever again (at least not in
web pages delivered by Bloodhound project ;) . One strong reason for doing
so is that all relationships between products and other resources involve
product prefix , so if prefix may be changed then there are two choices :
1. previous relationships will be broken
2. whatever relationship involving products (not just limited to
Bloodhound,
considering the fact that other plugins may add their own links too)
will need to be updated
IMO option '''1''' is unacceptable whereas option '''2''' is hard to
maintain in practice and prefix updates might take a '''very''' long time
(even if data consistency is ensured , which is a whole subject on its
own) . So users who want to change product prefix should use external
tools , scripts , ... in order to get that done .
--
Ticket URL: <https://issues.apache.org/bloodhound/ticket/108>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound (incubating) issue tracker
Re: [Apache Bloodhound] #108: Prevent changing product prefix
Posted by Apache Bloodhound <bl...@incubator.apache.org>.
#108: Prevent changing product prefix
---------------------------+----------------------------------------
Reporter: olemis | Owner: gjm
Type: defect | Status: accepted
Priority: critical | Milestone: RC1 for initial release
Component: multiproduct | Version:
Resolution: | Keywords: db relationships integrity
---------------------------+----------------------------------------
Comment (by gjm):
r1353652 and r1353654 makes the product prefix appear not editable if the
product exists (theme and multiproduct copies of the template respectively
r1353655 fixes the same readonly attribute to allow a product to be
created from the products pages
--
Ticket URL: <https://issues.apache.org/bloodhound/ticket/108#comment:4>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound (incubating) issue tracker
Re: [Apache Bloodhound] #108: Prevent changing product prefix
Posted by Apache Bloodhound <bl...@incubator.apache.org>.
#108: Prevent changing product prefix
---------------------------+----------------------------------------
Reporter: olemis | Owner: nobody
Type: defect | Status: reopened
Priority: critical | Milestone: RC1 for initial release
Component: multiproduct | Version:
Resolution: | Keywords: db relationships integrity
---------------------------+----------------------------------------
Changes (by olemis):
* status: closed => reopened
* resolution: worksforme =>
Comment:
afaics product admin panel allows to change it .
--
Ticket URL: <https://issues.apache.org/bloodhound/ticket/108#comment:2>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound (incubating) issue tracker
Re: [Apache Bloodhound] #108: Prevent product prefix from appearing
editable
Posted by Apache Bloodhound <bl...@incubator.apache.org>.
#108: Prevent product prefix from appearing editable
---------------------------+----------------------------------------
Reporter: olemis | Owner: gjm
Type: defect | Status: accepted
Priority: critical | Milestone: RC1 for initial release
Component: multiproduct | Version:
Resolution: | Keywords: db relationships integrity
---------------------------+----------------------------------------
Comment (by gjm):
I probably went too far with the first two commits as they do not need
logic on the readonly attribute like the products pages do - I will fix
this later
--
Ticket URL: <https://issues.apache.org/bloodhound/ticket/108#comment:6>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound (incubating) issue tracker
Re: [Apache Bloodhound] #108: Prevent changing product prefix
Posted by Apache Bloodhound <bl...@incubator.apache.org>.
#108: Prevent changing product prefix
---------------------------+----------------------------------------
Reporter: olemis | Owner: nobody
Type: defect | Status: closed
Priority: critical | Milestone: RC1 for initial release
Component: multiproduct | Version:
Resolution: worksforme | Keywords: db relationships integrity
---------------------------+----------------------------------------
Changes (by gjm):
* status: new => closed
* resolution: => worksforme
Comment:
This is already the case.
--
Ticket URL: <https://issues.apache.org/bloodhound/ticket/108#comment:1>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound (incubating) issue tracker
Re: [Apache Bloodhound] #108: Prevent changing product prefix
Posted by Apache Bloodhound <bl...@incubator.apache.org>.
#108: Prevent changing product prefix
---------------------------+----------------------------------------
Reporter: olemis | Owner: gjm
Type: defect | Status: accepted
Priority: critical | Milestone: RC1 for initial release
Component: multiproduct | Version:
Resolution: | Keywords: db relationships integrity
---------------------------+----------------------------------------
Changes (by gjm):
* owner: nobody => gjm
* status: reopened => accepted
Comment:
Well, it doesn't make it true. The page implies that it is editable.
I was going to raise new tickets for related issues but I will correct the
errors here instead.
--
Ticket URL: <https://issues.apache.org/bloodhound/ticket/108#comment:3>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound (incubating) issue tracker
Re: [Apache Bloodhound] #108: Prevent product prefix from appearing
editable
Posted by Apache Bloodhound <bl...@incubator.apache.org>.
#108: Prevent product prefix from appearing editable
---------------------------+----------------------------------------
Reporter: olemis | Owner: gjm
Type: defect | Status: closed
Priority: critical | Milestone: RC1 for initial release
Component: multiproduct | Version:
Resolution: fixed | Keywords: db relationships integrity
---------------------------+----------------------------------------
Changes (by gjm):
* status: accepted => closed
* resolution: => fixed
Comment:
r1353932 and r1353934 remove the unneeded readonly logic on the product
admin templates
--
Ticket URL: <https://issues.apache.org/bloodhound/ticket/108#comment:7>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound (incubating) issue tracker
Re: [Apache Bloodhound] #108: Prevent product prefix from appearing
editable (was: Prevent changing product prefix)
Posted by Apache Bloodhound <bl...@incubator.apache.org>.
#108: Prevent product prefix from appearing editable
---------------------------+----------------------------------------
Reporter: olemis | Owner: gjm
Type: defect | Status: accepted
Priority: critical | Milestone: RC1 for initial release
Component: multiproduct | Version:
Resolution: | Keywords: db relationships integrity
---------------------------+----------------------------------------
Old description:
> Product prefix should be considered as an immutable identifier set once
> at product creation time . It must not be changed ever again (at least
> not in web pages delivered by Bloodhound project ;) . One strong reason
> for doing so is that all relationships between products and other
> resources involve product prefix , so if prefix may be changed then there
> are two choices :
>
> 1. previous relationships will be broken
> 2. whatever relationship involving products (not just limited to
> Bloodhound,
> considering the fact that other plugins may add their own links too)
> will need to be updated
>
> IMO option '''1''' is unacceptable whereas option '''2''' is hard to
> maintain in practice and prefix updates might take a '''very''' long time
> (even if data consistency is ensured , which is a whole subject on its
> own) . So users who want to change product prefix should use external
> tools , scripts , ... in order to get that done .
New description:
Product prefixes are not editable but the admin interface appears to
suggest that they are. Make prefix fields appear uneditable at the
appropriate time.
--
Comment (by gjm):
Changing title and description to be a little more accurate
--
Ticket URL: <https://issues.apache.org/bloodhound/ticket/108#comment:5>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound (incubating) issue tracker