You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2018/05/10 21:19:38 UTC
[GitHub] codecov-io commented on issue #4947: [sql lab] a better approach at
limiting queries
codecov-io commented on issue #4947: [sql lab] a better approach at limiting queries
URL: https://github.com/apache/incubator-superset/pull/4947#issuecomment-388189481
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4947?src=pr&el=h1) Report
> Merging [#4947](https://codecov.io/gh/apache/incubator-superset/pull/4947?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/b75942daa51014d49b707f7b5d7fe792b46b56c6?src=pr&el=desc) will **increase** coverage by `0.02%`.
> The diff coverage is `95.45%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/4947/graphs/tree.svg?height=150&width=650&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/4947?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4947 +/- ##
==========================================
+ Coverage 77.1% 77.12% +0.02%
==========================================
Files 44 44
Lines 8636 8640 +4
==========================================
+ Hits 6659 6664 +5
+ Misses 1977 1976 -1
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/4947?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/sql\_lab.py](https://codecov.io/gh/apache/incubator-superset/pull/4947/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX2xhYi5weQ==) | `75.4% <100%> (+0.95%)` | :arrow_up: |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/4947/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `86.47% <100%> (-0.08%)` | :arrow_down: |
| [superset/sql\_parse.py](https://codecov.io/gh/apache/incubator-superset/pull/4947/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3BhcnNlLnB5) | `98.79% <100%> (-0.06%)` | :arrow_down: |
| [superset/db\_engine\_specs.py](https://codecov.io/gh/apache/incubator-superset/pull/4947/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzLnB5) | `53.28% <92.85%> (+0.81%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4947?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4947?src=pr&el=footer). Last update [b75942d...94b939d](https://codecov.io/gh/apache/incubator-superset/pull/4947?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org