You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@polaris.apache.org by "rishii-19-works (via GitHub)" <gi...@apache.org> on 2026/01/08 02:11:22 UTC
[PR] Document limitation of event data availability in generic table events [polaris]
rishii-19-works opened a new pull request, #3380:
URL: https://github.com/apache/polaris/pull/3380
This PR documents the current limitation where only API response data is available to After* events in the generic table flow.
The createGenericTable path is used as a concrete example to highlight that intermediate objects created earlier in the request lifecycle are not accessible during event emission.
This provides a concrete starting point for introducing a request-scoped mechanism to pass non-response data to events, as discussed in #3209.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Document limitation of event data availability in generic table events [polaris]
Posted by "dimas-b (via GitHub)" <gi...@apache.org>.
dimas-b commented on code in PR #3380:
URL: https://github.com/apache/polaris/pull/3380#discussion_r2674149142
##########
polaris-core/src/main/java/org/apache/polaris/core/storage/aws/AwsStorageConfigurationInfo.java:
##########
@@ -47,9 +47,11 @@ public static ImmutableAwsStorageConfigurationInfo.Builder builder() {
// Technically, it should be ^arn:(aws|aws-cn|aws-us-gov):iam::(\d{12}):role/.+$, but we've
// generalized it to support non-aws S3 implementations
- @JsonIgnore public static final String ROLE_ARN_PATTERN = "^.+:(.*):iam:.*:(.*):role/.+$";
+ @JsonIgnore
+ public static final String ROLE_ARN_PATTERN = "^.+:(.*):iam:.*:(.*):role/.+$";
Review Comment:
-1 This change is irrelevant to the purpose of this PR stated in the description.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Document limitation of event data availability in generic table events [polaris]
Posted by "adnanhemani (via GitHub)" <gi...@apache.org>.
adnanhemani commented on PR #3380:
URL: https://github.com/apache/polaris/pull/3380#issuecomment-3725969180
I'm sorry, I'm not sure I see any utility in any part of this PR. The point of #3209 is not to "document" anything, but to come up with a solution. Anyone who reads and understands the code is aware of this limitation - documentation does not change anything.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Document limitation of event data availability in generic table events [polaris]
Posted by "dimas-b (via GitHub)" <gi...@apache.org>.
dimas-b commented on code in PR #3380:
URL: https://github.com/apache/polaris/pull/3380#discussion_r2673118661
##########
runtime/service/src/main/java/org/apache/polaris/service/catalog/generic/CatalogGenericTableEventServiceDelegator.java:
##########
@@ -52,19 +52,32 @@ public Response createGenericTable(
CreateGenericTableRequest createGenericTableRequest,
RealmContext realmContext,
SecurityContext securityContext) {
+
Review Comment:
nit: these whitespace change appear to be irrelevant to the purpose of the PR. Since the PR does not attempt to refactor code, why introduce whitespace changes? IMHO, they complicate review.
##########
runtime/service/src/main/java/org/apache/polaris/service/catalog/generic/CatalogGenericTableEventServiceDelegator.java:
##########
@@ -52,19 +52,32 @@ public Response createGenericTable(
CreateGenericTableRequest createGenericTableRequest,
RealmContext realmContext,
SecurityContext securityContext) {
+
String catalogName = prefixParser.prefixToCatalogName(realmContext, prefix);
+
polarisEventListener.onBeforeCreateGenericTable(
new CatalogGenericTableServiceEvents.BeforeCreateGenericTableEvent(
eventMetadataFactory.create(), catalogName, namespace, createGenericTableRequest));
+
Response resp =
delegate.createGenericTable(
prefix, namespace, createGenericTableRequest, realmContext, securityContext);
+
+ LoadGenericTableResponse responseEntity = (LoadGenericTableResponse) resp.getEntity();
Review Comment:
same here: why extract a variable when the PR's intention is to "document" ? 🤔
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Implement intermediate data support for events (based on #3391) [polaris]
Posted by "rishii-19-works (via GitHub)" <gi...@apache.org>.
rishii-19-works commented on PR #3380:
URL: https://github.com/apache/polaris/pull/3380#issuecomment-3727255168
Closing this draft PR to rework it based on the approach proposed in #3391. I’ll open a new PR once aligned.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Document limitation of event data availability in generic table events [polaris]
Posted by "dimas-b (via GitHub)" <gi...@apache.org>.
dimas-b commented on PR #3380:
URL: https://github.com/apache/polaris/pull/3380#issuecomment-3724763832
@adnanhemani : FYI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Document limitation of event data availability in generic table events [polaris]
Posted by "rishii-19-works (via GitHub)" <gi...@apache.org>.
rishii-19-works commented on code in PR #3380:
URL: https://github.com/apache/polaris/pull/3380#discussion_r2674177954
##########
polaris-core/src/main/java/org/apache/polaris/core/storage/aws/AwsStorageConfigurationInfo.java:
##########
@@ -47,9 +47,11 @@ public static ImmutableAwsStorageConfigurationInfo.Builder builder() {
// Technically, it should be ^arn:(aws|aws-cn|aws-us-gov):iam::(\d{12}):role/.+$, but we've
// generalized it to support non-aws S3 implementations
- @JsonIgnore public static final String ROLE_ARN_PATTERN = "^.+:(.*):iam:.*:(.*):role/.+$";
+ @JsonIgnore
+ public static final String ROLE_ARN_PATTERN = "^.+:(.*):iam:.*:(.*):role/.+$";
Review Comment:
Thanks for the review. I understand the concern about the irrelevant changes.
I’ll clean up the PR to keep it strictly scoped to the intended change and remove any unrelated modifications. I’ll update the PR shortly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Document limitation of event data availability in generic table events [polaris]
Posted by "rishii-19-works (via GitHub)" <gi...@apache.org>.
rishii-19-works commented on PR #3380:
URL: https://github.com/apache/polaris/pull/3380#issuecomment-3726242663
Thanks for the review. I understand the concern about the irrelevant changes.
I’ll clean up the PR to keep it strictly scoped to the intended change and remove any unrelated modifications. I’ll update the PR shortly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Implement intermediate data support for events (based on #3391) [polaris]
Posted by "rishii-19-works (via GitHub)" <gi...@apache.org>.
rishii-19-works closed pull request #3380: Implement intermediate data support for events (based on #3391)
URL: https://github.com/apache/polaris/pull/3380
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org