Re: [PR] chore(server): clear context after req done [incubator-hugegraph]

["javeme (via GitHub)" <gi...@apache.org>]

javeme commented on code in PR #2470:
URL: https://github.com/apache/incubator-hugegraph/pull/2470#discussion_r1536628021


##########
hugegraph-server/hugegraph-api/src/main/java/org/apache/hugegraph/auth/HugeAuthenticator.java:
##########
@@ -107,7 +107,7 @@ default User authenticate(final Map<String, String> credentials)
         }
 
         HugeGraphAuthProxy.logUser(user, credentials.get(KEY_PATH));
-        // Set authentication context & unset in AccessLogFilter
+        // TODO: Ensure context lifecycle in GraphServer & AuthServer(#AccessLogFilter)

Review Comment:
   don't need TODO mark anymore since it's done



##########
hugegraph-server/hugegraph-api/src/main/java/org/apache/hugegraph/api/filter/AccessLogFilter.java:
##########
@@ -122,7 +122,7 @@ public void filter(ContainerRequestContext requestContext,
 
         // Unset the context in "HugeAuthenticator", need distinguish Graph/Auth server lifecycle
         GraphManager manager = managerProvider.get();
-        // TODO transfer Authorizer if we need after.
+        // TODO: transfer Authorizer if we need after.

Review Comment:
   don't need TODO mark anymore since it's done



##########
hugegraph-server/hugegraph-api/src/main/java/org/apache/hugegraph/api/filter/AuthenticationFilter.java:
##########
@@ -76,7 +76,7 @@ public class AuthenticationFilter implements ContainerRequestFilter {
             "versions",
             "openapi.json"
     );
-    // Remove auth/login API from white list
+    /** Remove auth/login API from whitelist */

Review Comment:
   one * is ok



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For additional commands, e-mail: issues-help@hugegraph.apache.org