You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@apr.apache.org by Jeff Trawick <tr...@attglobal.net> on 2001/09/19 23:41:54 UTC

Re: cvs commit: apr/locks/win32 proc_mutex.c

rbb@apache.org writes:

>   New process locking API for APR.
>   
>   Submitted by:	Aaron Bannert <aa...@clove.org>

>   1.1                  apr/locks/unix/proc_mutex.c
>   
>   Index: proc_mutex.c
>   ===================================================================
...
>       if ((stat = pthread_mutexattr_init(&mattr))) {
>   #ifdef PTHREAD_SETS_ERRNO
>           stat = errno;
>   #endif
>           proc_pthread_cleanup(new_mutex);

Is this supposed to be proc_mutex_proc_pthread_cleanup()?  I'm getting
a bunch of unresolved references to proc_pthread_cleanup() on
Solaris.  We do have a function called proc_pthread_cleanup(), but
that is static in crossproc.c.

-- 
Jeff Trawick | trawick@attglobal.net | PGP public key at web site:
       http://www.geocities.com/SiliconValley/Park/9289/
             Born in Roswell... married an alien...

Re: cvs commit: apr/locks/win32 proc_mutex.c

Posted by Aaron Bannert <aa...@clove.org>.
On Wed, Sep 19, 2001 at 05:41:54PM -0400, Jeff Trawick wrote:
> rbb@apache.org writes:
> 
> >   New process locking API for APR.
> >   
> >   Submitted by:	Aaron Bannert <aa...@clove.org>
> 
> >   1.1                  apr/locks/unix/proc_mutex.c
> >   
> >   Index: proc_mutex.c
> >   ===================================================================
> ...
> >       if ((stat = pthread_mutexattr_init(&mattr))) {
> >   #ifdef PTHREAD_SETS_ERRNO
> >           stat = errno;
> >   #endif
> >           proc_pthread_cleanup(new_mutex);
> 
> Is this supposed to be proc_mutex_proc_pthread_cleanup()?  I'm getting
> a bunch of unresolved references to proc_pthread_cleanup() on
> Solaris.  We do have a function called proc_pthread_cleanup(), but
> that is static in crossproc.c.

Yes, it should be proc_mutex_proc_pthread_cleanup() (yuck!). I believe
I fixed that in my tree, but I guess it didn't make it into the patch.

thanks,
aaron