You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2020/12/12 16:40:47 UTC
[GitHub] [netbeans] matthiasblaesing opened a new pull request #2589: [NETBEANS-5142] LSP Client creates excessive processes
matthiasblaesing opened a new pull request #2589:
URL: https://github.com/apache/netbeans/pull/2589
The caching of the LSP client that is rooted in project2MimeType2Server
does not work. In the WeakHashMap the keys are help by weak references
and the key is invalidated, once it is GCed. The URIs that are used
as keys become immediately eligible for GC and thus the cache is not
used at all.
To fix this, use a regular HashMap with WeakReference values.
The LSP Clients themselves are either strongly referenced from other
components or can be collected. To not create excessive start/stops of
servers, an additional strong reference is retained for a certain time
after the last bind request was issued. Only after the timeout has
occured, that extra reference is released and the bindings could become
eligible for GC.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] matthiasblaesing merged pull request #2589: [NETBEANS-5142] LSP Client creates excessive processes
Posted by GitBox <gi...@apache.org>.
matthiasblaesing merged pull request #2589:
URL: https://github.com/apache/netbeans/pull/2589
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] matthiasblaesing commented on pull request #2589: [NETBEANS-5142] LSP Client creates excessive processes
Posted by GitBox <gi...@apache.org>.
matthiasblaesing commented on pull request #2589:
URL: https://github.com/apache/netbeans/pull/2589#issuecomment-743981962
@jlahoda thank you for the pointer. The 'activeReferenceQueue` looks indeed like the better (and simpler) solution.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] matthiasblaesing commented on pull request #2589: [NETBEANS-5142] LSP Client creates excessive processes
Posted by GitBox <gi...@apache.org>.
matthiasblaesing commented on pull request #2589:
URL: https://github.com/apache/netbeans/pull/2589#issuecomment-743823771
@jlahoda @JaroslavTulach you both worked in the area of the lsp client. I documented my reasoning in the commit message and the issue report but the TL;DR version is: I worked with angular applications and noticed, that the whole system became sluggish, investigating I found that a massive number of node processes was running as children of the netbeans process. That started my investigation and my finding is, that the caching/reuse of the LSP client does not work and every request for LSP bindings results in a new process being started.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] matthiasblaesing commented on pull request #2589: [NETBEANS-5142] LSP Client creates excessive processes
Posted by GitBox <gi...@apache.org>.
matthiasblaesing commented on pull request #2589:
URL: https://github.com/apache/netbeans/pull/2589#issuecomment-744682396
Thank you both - I'm pretty sure I introduced my own set of bugs :-)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] JaroslavTulach commented on pull request #2589: [NETBEANS-5142] LSP Client creates excessive processes
Posted by GitBox <gi...@apache.org>.
JaroslavTulach commented on pull request #2589:
URL: https://github.com/apache/netbeans/pull/2589#issuecomment-744159187
> worked with .... applications and noticed, that the whole system became sluggish, investigating I found that a massive number of node processes was running as children of the netbeans process
I have actually seen the enormous multiplication of the `node` processes as well. Alas, I haven't concluded it is my own error.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists