[Impala-ASF-CR] IMPALA-10975: Refactor alter table ddl operation

["Sourabh Goyal (Code Review)" <ge...@cloudera.org>]

Hello Vihang Karajgaonkar, Yu-Wen Lai, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/17919

to look at the new patch set (#7).

Change subject: IMPALA-10975: Refactor alter table ddl operation
......................................................................

IMPALA-10975: Refactor alter table ddl operation

For almost all alter table DDL operations in catalogOpExecutor,
a table is added to catalog update at a common place in the end
if reloadMetadata is true. However for few sub ddl operations like ADD
and DROP partitions, addTableToCatalogUpdate() is called locally.
This patch is to refactor addTableToCatalogUpdate() and call it at one
place for all the sub ddls.

After this patch, a table (after alter table ddl) is added to catalog
update if its old catalog version does not match the current catalog
version.

This patch also addresses a bug in which a HMS event was getting
added to delete event log even if event processing is not active.

Testing:
Relying on existing tests since it is a minor refactoring.

Change-Id: Ifbadcab68b4599ad18b681b1284052a47b74d802
---
M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
1 file changed, 36 insertions(+), 31 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/19/17919/7
-- 
To view, visit http://gerrit.cloudera.org:8080/17919
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ifbadcab68b4599ad18b681b1284052a47b74d802
Gerrit-Change-Number: 17919
Gerrit-PatchSet: 7
Gerrit-Owner: Sourabh Goyal <so...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Sourabh Goyal <so...@cloudera.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Reviewer: Yu-Wen Lai <yu...@cloudera.com>