You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Yingchun Lai (Code Review)" <ge...@cloudera.org> on 2023/07/28 03:37:58 UTC
[kudu-CR](branch-1.17.x) [tools] KUDU-3487 rebalancer checks the voter num.
Hello Alexey Serbin, Kudu Jenkins,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/20277
to review the following change.
Change subject: [tools] KUDU-3487 rebalancer checks the voter num.
......................................................................
[tools] KUDU-3487 rebalancer checks the voter num.
Replace rebalance for the tables whose replication factor is 1 might
stuck for a long time because the rebalancer send LeaderStepDown request
even if there is no other voter to transfer leadership.
So check the voter num before sending the request.
Change-Id: I3b3d5dfb383719f56a2d32b62d2b659b17928794
Reviewed-on: http://gerrit.cloudera.org:8080/20264
Tested-by: Kudu Jenkins
Reviewed-by: Alexey Serbin <al...@apache.org>
(cherry picked from commit 8369b3771c4ee58dcc20068626e64a212717cc65)
---
M src/kudu/tools/tool_replica_util.cc
1 file changed, 3 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/77/20277/1
--
To view, visit http://gerrit.cloudera.org:8080/20277
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.17.x
Gerrit-MessageType: newchange
Gerrit-Change-Id: I3b3d5dfb383719f56a2d32b62d2b659b17928794
Gerrit-Change-Number: 20277
Gerrit-PatchSet: 1
Gerrit-Owner: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Song Jiacheng <so...@thinkingdata.cn>
[kudu-CR](branch-1.17.x) [tools] KUDU-3487 rebalancer checks the voter num.
Posted by "Yingchun Lai (Code Review)" <ge...@cloudera.org>.
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/20277 )
Change subject: [tools] KUDU-3487 rebalancer checks the voter num.
......................................................................
Patch Set 1: Verified+1 Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/20277
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.17.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I3b3d5dfb383719f56a2d32b62d2b659b17928794
Gerrit-Change-Number: 20277
Gerrit-PatchSet: 1
Gerrit-Owner: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Song Jiacheng <so...@thinkingdata.cn>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Comment-Date: Fri, 28 Jul 2023 07:22:46 +0000
Gerrit-HasComments: No
[kudu-CR](branch-1.17.x) [tools] KUDU-3487 rebalancer checks the voter num.
Posted by "Yingchun Lai (Code Review)" <ge...@cloudera.org>.
Yingchun Lai has removed a vote on this change.
Change subject: [tools] KUDU-3487 rebalancer checks the voter num.
......................................................................
Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/20277
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.17.x
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I3b3d5dfb383719f56a2d32b62d2b659b17928794
Gerrit-Change-Number: 20277
Gerrit-PatchSet: 1
Gerrit-Owner: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Song Jiacheng <so...@thinkingdata.cn>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
[kudu-CR](branch-1.17.x) [tools] KUDU-3487 rebalancer checks the voter num.
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/20277 )
Change subject: [tools] KUDU-3487 rebalancer checks the voter num.
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/20277
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.17.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I3b3d5dfb383719f56a2d32b62d2b659b17928794
Gerrit-Change-Number: 20277
Gerrit-PatchSet: 1
Gerrit-Owner: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Song Jiacheng <so...@thinkingdata.cn>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Comment-Date: Fri, 28 Jul 2023 15:50:02 +0000
Gerrit-HasComments: No
[kudu-CR](branch-1.17.x) [tools] KUDU-3487 rebalancer checks the voter num.
Posted by "Song Jiacheng (Code Review)" <ge...@cloudera.org>.
Song Jiacheng has posted comments on this change. ( http://gerrit.cloudera.org:8080/20277 )
Change subject: [tools] KUDU-3487 rebalancer checks the voter num.
......................................................................
Patch Set 1:
> > Patch Set 1:
> >
> > Hi,
> > It seems that the patch build failed in branch 1.17, do I need to
> do something to fix this?
>
> Not needed, the failure is caused by the Jenkins itself, no related
> to the newly added code.
Got it, thanks!
--
To view, visit http://gerrit.cloudera.org:8080/20277
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.17.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I3b3d5dfb383719f56a2d32b62d2b659b17928794
Gerrit-Change-Number: 20277
Gerrit-PatchSet: 1
Gerrit-Owner: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Song Jiacheng <so...@thinkingdata.cn>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Comment-Date: Fri, 28 Jul 2023 07:30:12 +0000
Gerrit-HasComments: No
[kudu-CR](branch-1.17.x) [tools] KUDU-3487 rebalancer checks the voter num.
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/20277 )
Change subject: [tools] KUDU-3487 rebalancer checks the voter num.
......................................................................
[tools] KUDU-3487 rebalancer checks the voter num.
Replace rebalance for the tables whose replication factor is 1 might
stuck for a long time because the rebalancer send LeaderStepDown request
even if there is no other voter to transfer leadership.
So check the voter num before sending the request.
Change-Id: I3b3d5dfb383719f56a2d32b62d2b659b17928794
Reviewed-on: http://gerrit.cloudera.org:8080/20264
Tested-by: Kudu Jenkins
Reviewed-by: Alexey Serbin <al...@apache.org>
(cherry picked from commit 8369b3771c4ee58dcc20068626e64a212717cc65)
Reviewed-on: http://gerrit.cloudera.org:8080/20277
Reviewed-by: Yingchun Lai <la...@apache.org>
Tested-by: Yingchun Lai <la...@apache.org>
---
M src/kudu/tools/tool_replica_util.cc
1 file changed, 3 insertions(+), 1 deletion(-)
Approvals:
Yingchun Lai: Looks good to me, approved; Verified
Alexey Serbin: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/20277
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.17.x
Gerrit-MessageType: merged
Gerrit-Change-Id: I3b3d5dfb383719f56a2d32b62d2b659b17928794
Gerrit-Change-Number: 20277
Gerrit-PatchSet: 2
Gerrit-Owner: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Song Jiacheng <so...@thinkingdata.cn>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
[kudu-CR](branch-1.17.x) [tools] KUDU-3487 rebalancer checks the voter num.
Posted by "Song Jiacheng (Code Review)" <ge...@cloudera.org>.
Song Jiacheng has posted comments on this change. ( http://gerrit.cloudera.org:8080/20277 )
Change subject: [tools] KUDU-3487 rebalancer checks the voter num.
......................................................................
Patch Set 1:
Hi,
It seems that the patch build failed in branch 1.17, do I need to do something to fix this?
--
To view, visit http://gerrit.cloudera.org:8080/20277
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.17.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I3b3d5dfb383719f56a2d32b62d2b659b17928794
Gerrit-Change-Number: 20277
Gerrit-PatchSet: 1
Gerrit-Owner: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Song Jiacheng <so...@thinkingdata.cn>
Gerrit-Comment-Date: Fri, 28 Jul 2023 06:26:57 +0000
Gerrit-HasComments: No
[kudu-CR](branch-1.17.x) [tools] KUDU-3487 rebalancer checks the voter num.
Posted by "Yingchun Lai (Code Review)" <ge...@cloudera.org>.
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/20277 )
Change subject: [tools] KUDU-3487 rebalancer checks the voter num.
......................................................................
Patch Set 1:
> Patch Set 1:
>
> Hi,
> It seems that the patch build failed in branch 1.17, do I need to do something to fix this?
Not needed, the failure is caused by the Jenkins itself, no related to the newly added code.
--
To view, visit http://gerrit.cloudera.org:8080/20277
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.17.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I3b3d5dfb383719f56a2d32b62d2b659b17928794
Gerrit-Change-Number: 20277
Gerrit-PatchSet: 1
Gerrit-Owner: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Song Jiacheng <so...@thinkingdata.cn>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Comment-Date: Fri, 28 Jul 2023 07:22:39 +0000
Gerrit-HasComments: No