You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "Zakelly (via GitHub)" <gi...@apache.org> on 2024/01/22 17:32:51 UTC
[PR] [FLINK-34190][FLIP-416][checkpointing] Deprecate RestoreMode#LEGACY [flink]
Zakelly opened a new pull request, #24169:
URL: https://github.com/apache/flink/pull/24169
## What is the purpose of the change
In FLIP-416, we decided to deprecate and remove the RestoreMode#LEGACY. This PR facilitate the deprecation.
## Brief change log
*(for example:)*
- Annotate RestoreMode#LEGACY with @Deprecated
- Doc
- Deprecation messages in CLI and REST API
## Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / **no**)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (**yes** / no)
- The serializers: (yes / **no** / don't know)
- The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
- Anything that affects deployment or recovery: JobManager (and its components), **Checkpointing**, Kubernetes/Yarn, ZooKeeper: (yes / no / don't know)
- The S3 file system connector: (yes / **no** / don't know)
## Documentation
- Does this pull request introduce a new feature? (yes / **no**)
- If yes, how is the feature documented? (not applicable / **docs** / **JavaDocs** / not documented)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-34190][FLIP-416][checkpoint] Deprecate RestoreMode#LEGACY [flink]
Posted by "Zakelly (via GitHub)" <gi...@apache.org>.
Zakelly commented on PR #24169:
URL: https://github.com/apache/flink/pull/24169#issuecomment-1905819495
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-34190][FLIP-416][checkpoint] Deprecate RestoreMode#LEGACY [flink]
Posted by "Zakelly (via GitHub)" <gi...@apache.org>.
Zakelly commented on PR #24169:
URL: https://github.com/apache/flink/pull/24169#issuecomment-1906452618
@masteryhx Thanks for your detailed review! I modified accordingly, PTAL. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-34190][FLIP-416][checkpoint] Deprecate RestoreMode#LEGACY [flink]
Posted by "masteryhx (via GitHub)" <gi...@apache.org>.
masteryhx commented on PR #24169:
URL: https://github.com/apache/flink/pull/24169#issuecomment-1908172514
merged f7a2819f...bed79d33 into master
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-34190][FLIP-416][checkpoint] Deprecate RestoreMode#LEGACY [flink]
Posted by "flinkbot (via GitHub)" <gi...@apache.org>.
flinkbot commented on PR #24169:
URL: https://github.com/apache/flink/pull/24169#issuecomment-1904493250
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "9904b58ef64504af0dc286e096be3fc00fbdf303",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "9904b58ef64504af0dc286e096be3fc00fbdf303",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 9904b58ef64504af0dc286e096be3fc00fbdf303 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-34190][FLIP-416][checkpoint] Deprecate RestoreMode#LEGACY [flink]
Posted by "Zakelly (via GitHub)" <gi...@apache.org>.
Zakelly commented on PR #24169:
URL: https://github.com/apache/flink/pull/24169#issuecomment-1906107953
Hi @masteryhx , would you please review this one?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-34190][FLIP-416][checkpoint] Deprecate RestoreMode#LEGACY [flink]
Posted by "masteryhx (via GitHub)" <gi...@apache.org>.
masteryhx closed pull request #24169: [FLINK-34190][FLIP-416][checkpoint] Deprecate RestoreMode#LEGACY
URL: https://github.com/apache/flink/pull/24169
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org