You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/10/10 06:33:34 UTC
[GitHub] [shardingsphere] strongduanmu opened a new issue, #19562: Consider refactoring SQLParserTestCases to avoid excessive line counts
strongduanmu opened a new issue, #19562:
URL: https://github.com/apache/shardingsphere/issues/19562
## Feature Request
### Is your feature request related to a problem?
No.
### Describe the feature you would like.
Currently, the SQLParserTestCases class adds a row for each additional SQL parsing, which results in the class having too many rows. Therefore, we need to refactor SQLParserTestCases to reduce unnecessary logic to improve the maintainability of the SQLParserTestCases class.
https://github.com/apache/shardingsphere/blob/master/shardingsphere-test/shardingsphere-parser-test/src/main/java/org/apache/shardingsphere/test/sql/parser/parameterized/jaxb/cases/domain/SQLParserTestCases.java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] LeeGuoPing commented on issue #19562: Consider refactoring SQLParserTestCases to avoid excessive line counts
Posted by GitBox <gi...@apache.org>.
LeeGuoPing commented on issue #19562:
URL: https://github.com/apache/shardingsphere/issues/19562#issuecomment-1196299207
May I have a try
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] strongduanmu commented on issue #19562: Consider refactoring SQLParserTestCases to avoid excessive line counts
Posted by GitBox <gi...@apache.org>.
strongduanmu commented on issue #19562:
URL: https://github.com/apache/shardingsphere/issues/19562#issuecomment-1196299616
@LeeGuoPing Welcome.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] github-actions[bot] commented on issue #19562: Consider refactoring SQLParserTestCases to avoid excessive line counts
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on issue #19562:
URL: https://github.com/apache/shardingsphere/issues/19562#issuecomment-1272349213
Hello , this issue has not received a reply for several days.
This issue is supposed to be closed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] github-actions[bot] closed issue #19562: Consider refactoring SQLParserTestCases to avoid excessive line counts
Posted by GitBox <gi...@apache.org>.
github-actions[bot] closed issue #19562: Consider refactoring SQLParserTestCases to avoid excessive line counts
URL: https://github.com/apache/shardingsphere/issues/19562
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org