You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hbase.apache.org by Andrew Purtell <ap...@apache.org> on 2010/10/19 00:38:57 UTC
Review Request: [rest] Do not perform cache control when returning results
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.cloudera.org/r/1041/
-----------------------------------------------------------
Review request for hbase.
Summary
-------
The REST interface currently provides MaxAge hints to HTTP cache servers when returning results, but does not do so in a way that makes much sense. For some other responses such as scanner results or schema, the REST interface provides a NoCache hint. That seems appropriate. Otherwise, especially given the rich configuration languages of caching servers such as Varnish, it is probably not appropriate to manage cache policy in the REST interface.
This addresses bug HBASE-3121.
http://issues.apache.org/jira/browse/HBASE-3121
Diffs
-----
src/main/java/org/apache/hadoop/hbase/rest/RESTServlet.java ed92857
src/main/java/org/apache/hadoop/hbase/rest/RowResource.java a4cdd1c
src/main/java/org/apache/hadoop/hbase/rest/SchemaResource.java 0c134aa
Diff: http://review.cloudera.org/r/1041/diff
Testing
-------
Thanks,
Andrew
Re: Review Request: [rest] Do not perform cache control when returning
results
Posted by Ryan Rawson <ry...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.cloudera.org/r/1041/#review1562
-----------------------------------------------------------
Ship it!
- Ryan
On 2010-10-18 15:38:57, Andrew Purtell wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://review.cloudera.org/r/1041/
> -----------------------------------------------------------
>
> (Updated 2010-10-18 15:38:57)
>
>
> Review request for hbase.
>
>
> Summary
> -------
>
> The REST interface currently provides MaxAge hints to HTTP cache servers when returning results, but does not do so in a way that makes much sense. For some other responses such as scanner results or schema, the REST interface provides a NoCache hint. That seems appropriate. Otherwise, especially given the rich configuration languages of caching servers such as Varnish, it is probably not appropriate to manage cache policy in the REST interface.
>
>
> This addresses bug HBASE-3121.
> http://issues.apache.org/jira/browse/HBASE-3121
>
>
> Diffs
> -----
>
> src/main/java/org/apache/hadoop/hbase/rest/RESTServlet.java ed92857
> src/main/java/org/apache/hadoop/hbase/rest/RowResource.java a4cdd1c
> src/main/java/org/apache/hadoop/hbase/rest/SchemaResource.java 0c134aa
>
> Diff: http://review.cloudera.org/r/1041/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Andrew
>
>