You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/11/11 17:26:30 UTC

[GitHub] [spark] sarutak commented on a change in pull request #34551: [SPARK-37283][SQL] Don't try to store a V1 table which contains ANSI intervals in Hive compatible format

sarutak commented on a change in pull request #34551:
URL: https://github.com/apache/spark/pull/34551#discussion_r747687934



##########
File path: sql/hive/src/test/scala/org/apache/spark/sql/hive/MetastoreDataSourcesSuite.scala
##########
@@ -1403,6 +1403,69 @@ class MetastoreDataSourcesSuite extends QueryTest with SQLTestUtils with TestHiv
     }
   }
 
+  test("SPARK-37283: Don't try to store a V1 table which contains " +
+    "ANSI intervals in Hive compatible format") {
+    import DayTimeIntervalType.{DAY, HOUR, MINUTE, SECOND}
+    import YearMonthIntervalType.{MONTH, YEAR}
+    withTempPath{ dir =>
+      withTable("t") {
+        val bout = new java.io.ByteArrayOutputStream
+        Console.withOut(bout) {

Review comment:
       Oh, thank you. It's better.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org