[GitHub] [httpcomponents-core] michael-o commented on a change in pull request #241: Minor Improvement:

[GitBox <gi...@apache.org>]

michael-o commented on a change in pull request #241:
URL: https://github.com/apache/httpcomponents-core/pull/241#discussion_r550447686



##########
File path: httpcore5-testing/src/main/java/org/apache/hc/core5/benchmark/ResultFormatter.java
##########
@@ -36,9 +36,9 @@ private ResultFormatter() {
         // Do not allow utility class to be instantiated.
     }
 
-    static NumberFormat nf2 = NumberFormat.getInstance(Locale.ROOT);
-    static NumberFormat nf3 = NumberFormat.getInstance(Locale.ROOT);
-    static NumberFormat nf6 = NumberFormat.getInstance(Locale.ROOT);
+    static final NumberFormat nf2 = NumberFormat.getInstance(Locale.ROOT);

Review comment:
       Is this thread safe?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org