You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@accumulo.apache.org by ctubbsii <gi...@git.apache.org> on 2017/04/19 18:27:07 UTC
[GitHub] accumulo pull request #250: ACCUMULO-3384 support custom system props
GitHub user ctubbsii opened a pull request:
https://github.com/apache/accumulo/pull/250
ACCUMULO-3384 support custom system props
Add a property prefix for custom system-wide properties
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ctubbsii/accumulo ACCUMULO-3384-custom-props
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/accumulo/pull/250.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #250
----
commit c22031a9c67769bb0a90cbeeb9e935dd8accafbc
Author: Christopher Tubbs <ct...@apache.org>
Date: 2017-04-19T18:25:13Z
ACCUMULO-3384 support custom system props
Add a property prefix for custom system-wide properties
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] accumulo issue #250: ACCUMULO-3384 support custom system props
Posted by ctubbsii <gi...@git.apache.org>.
Github user ctubbsii commented on the issue:
https://github.com/apache/accumulo/pull/250
@joshelser It's poorly worded. It's not arbitrary system metadata. It's "accumulo system"-wide configuration for pluggable components. Currently, we have a prefix for arbitrary "per-table" configuration, but that's no good for things like volume choosers, pluggable security configuration options, etc.
Having this allows pluggable components to be configurable, without changing code, or requiring pluggable components use their own configuration system.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] accumulo issue #250: ACCUMULO-3384 support custom system props
Posted by joshelser <gi...@git.apache.org>.
Github user joshelser commented on the issue:
https://github.com/apache/accumulo/pull/250
> if config is needed system-wide for scan-time components or anything that might be pluggable which is run before the tables are online.
I can't really argue against the validity of providing some prefix for yet-to-be-defined server-side extensions (by definitions, those don't yet exist so I can't say if they're a good idea). Being able to configure such deployed code is a good idea.
However, the original list of "examples" from the ticket ("list contact information for a system owner or emergency contact, for display on a monitoring site; add notes about last time a system was manually rebooted or checked for healthy status.") is what bothered me. It seems like that really isn't the intent of this change -- I'd suggest (like Keith already did) to make this clear via the Property doc (and user manual).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] accumulo issue #250: ACCUMULO-3384 support custom system props
Posted by joshelser <gi...@git.apache.org>.
Github user joshelser commented on the issue:
https://github.com/apache/accumulo/pull/250
> even if we did have a section in the user manual covering these non-public modular API components in detail.
So we're adding support/features for things for the benefit of user customization that we don't actually intend to tell users how to use? We've reached another one of those impasses where I obviously don't understand your reasoning and don't care to continue re-hashing it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] accumulo issue #250: ACCUMULO-3384 support custom system props
Posted by ctubbsii <gi...@git.apache.org>.
Github user ctubbsii commented on the issue:
https://github.com/apache/accumulo/pull/250
@joshelser The property's own documentation is included in the user-manual appendix for properties. I didn't feel it needed a whole separate paragraph beyond that.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] accumulo issue #250: ACCUMULO-3384 support custom system props
Posted by keith-turner <gi...@git.apache.org>.
Github user keith-turner commented on the issue:
https://github.com/apache/accumulo/pull/250
> Having this allows pluggable components to be configurable, without changing code, or requiring pluggable components use their own configuration system.
@ctubbsii I think it would be useful to explain this in the props docs
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] accumulo issue #250: ACCUMULO-3384 support custom system props
Posted by ctubbsii <gi...@git.apache.org>.
Github user ctubbsii commented on the issue:
https://github.com/apache/accumulo/pull/250
@phrocker Mainly, because that was not the solution discussed back in Dec2015-Jan2016 on https://issues.apache.org/jira/browse/ACCUMULO-4085 and would not follow precedent of the per-table custom configs for iterators, per-table volume choosers, etc. It's also significantly more complex, and could create chicken-and-egg problems if config is needed system-wide for scan-time components or anything that might be pluggable which is run before the tables are online.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] accumulo issue #250: ACCUMULO-3384 support custom system props
Posted by joshelser <gi...@git.apache.org>.
Github user joshelser commented on the issue:
https://github.com/apache/accumulo/pull/250
This kind of feels like scope creep to me (why do we want to store arbitrary system metadata for users?) but whatever.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] accumulo issue #250: ACCUMULO-3384 support custom system props
Posted by joshelser <gi...@git.apache.org>.
Github user joshelser commented on the issue:
https://github.com/apache/accumulo/pull/250
@ctubbsii no user-manual update?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] accumulo issue #250: ACCUMULO-3384 support custom system props
Posted by joshelser <gi...@git.apache.org>.
Github user joshelser commented on the issue:
https://github.com/apache/accumulo/pull/250
Thanks for that.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] accumulo issue #250: ACCUMULO-3384 support custom system props
Posted by ctubbsii <gi...@git.apache.org>.
Github user ctubbsii commented on the issue:
https://github.com/apache/accumulo/pull/250
I've updated the ticket description to clarify the stronger use case for this feature, and will ensure that this is documented in the property prefix description, which I can link to from the javadoc in the various pluggable interfaces.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] accumulo pull request #250: ACCUMULO-3384 support custom system props
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/accumulo/pull/250
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] accumulo issue #250: ACCUMULO-3384 support custom system props
Posted by ctubbsii <gi...@git.apache.org>.
Github user ctubbsii commented on the issue:
https://github.com/apache/accumulo/pull/250
@phrocker I don't understand your comment about HDFS features. This issue is completely unrelated to HDFS features, as is ACCUMULO-4085.
As I've mentioned, this is specifically to provide a cluster-wide configuration store for user-created implementations of our pluggable interfaces. VolumeChooser is one such thing, Balancer is another, iterators could use it for non-table-specific configs, the three pluggable security modules could also use it, etc.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] accumulo issue #250: ACCUMULO-3384 support custom system props
Posted by joshelser <gi...@git.apache.org>.
Github user joshelser commented on the issue:
https://github.com/apache/accumulo/pull/250
> I didn't feel it needed a whole separate paragraph beyond that.
Wasn't suggesting its own paragraph, but I assume we have mention of instructions/descriptions around the aforementioned pluggable components (balancer, volume chooser) in which a link to the property would be beneficial (with a simple mention along the lines of "Implementations can use this property to configure blah blah"). Maybe I'm expecting too much and we don't actually have any documentation on these subjects?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] accumulo issue #250: ACCUMULO-3384 support custom system props
Posted by phrocker <gi...@git.apache.org>.
Github user phrocker commented on the issue:
https://github.com/apache/accumulo/pull/250
@ctubbsii I see. It seems that ACCUMULO-4085 is a specific issue that can be addressed with HDFS features. My comment was directed to the openness of this. You're suggesting the need for this for Accumulo internal features? Sorry for rehashing tickets that have been around a while, but I expect you know that is an expectation.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] accumulo issue #250: ACCUMULO-3384 support custom system props
Posted by ctubbsii <gi...@git.apache.org>.
Github user ctubbsii commented on the issue:
https://github.com/apache/accumulo/pull/250
@keith-turner Can do. Got a few more commits I want to create PRs for, which depend on this, then I can throw a doc-update on top of that.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] accumulo issue #250: ACCUMULO-3384 support custom system props
Posted by keith-turner <gi...@git.apache.org>.
Github user keith-turner commented on the issue:
https://github.com/apache/accumulo/pull/250
Would also be nice to update the javadoc for the plugins that could benefit from this prop to mention the prop.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] accumulo issue #250: ACCUMULO-3384 support custom system props
Posted by ctubbsii <gi...@git.apache.org>.
Github user ctubbsii commented on the issue:
https://github.com/apache/accumulo/pull/250
If you can think of something which will add value, by all means, I will support you... I just don't think anything else that I could say about it would be a valuable addition to the user manual.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] accumulo issue #250: ACCUMULO-3384 support custom system props
Posted by ctubbsii <gi...@git.apache.org>.
Github user ctubbsii commented on the issue:
https://github.com/apache/accumulo/pull/250
I cannot think of anything to add the user-manual which would add any value to what's already there. I think the user-manual is already too wordy, and repeating the same information in multiple places to suggest *possible* uses of a generic feature I think would be excessive, even if we did have a section in the user manual covering these non-public modular API components in detail.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] accumulo issue #250: ACCUMULO-3384 support custom system props
Posted by ctubbsii <gi...@git.apache.org>.
Github user ctubbsii commented on the issue:
https://github.com/apache/accumulo/pull/250
@joshelser That's not what I said at all. I didn't say I don't intend to tell users how to use it. I said that I think I sufficiently *did* explain how to use it.
I don't know what more you want from me. I added as much documentation as I felt was useful to add, and no more. I appreciate the fact that you feel it is still insufficient... but I did the best job I could with documenting it. If you want to add to it, please do so... I'm happy to support that... my feelings won't be hurt at all. But I've done the best I can with it at the moment and need to move on.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---