[GitHub] [servicecomb-java-chassis] Shoothzj commented on a diff in pull request #3001: update servo version

[GitBox <gi...@apache.org>]

Shoothzj commented on code in PR #3001:
URL: https://github.com/apache/servicecomb-java-chassis/pull/3001#discussion_r879444950


##########
metrics/metrics-core/src/test/java/org/apache/servicecomb/metrics/core/TestDefaultRegistryInitializer.java:
##########
@@ -44,7 +44,7 @@ public void init() {
     Assertions.assertEquals(-10, registryInitializer.getOrder());
     Assertions.assertTrue(globalRegistry.getDefaultRegistry() instanceof com.netflix.spectator.servo.ServoRegistry);
     Assertions.assertEquals(1, registries.size());
-    Assertions.assertEquals(1, DefaultMonitorRegistry.getInstance().getRegisteredMonitors().size());
+    Assertions.assertEquals(0, DefaultMonitorRegistry.getInstance().getRegisteredMonitors().size());

Review Comment:
   why change this to 0?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org