You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/10/28 15:15:32 UTC

[GitHub] [arrow] paleolimbot commented on a diff in pull request #14530: ARROW-18174: [R] Fix compile of altrep.cpp on some builds

paleolimbot commented on code in PR #14530:
URL: https://github.com/apache/arrow/pull/14530#discussion_r1008178156


##########
r/src/compute-exec.cpp:
##########
@@ -175,8 +175,8 @@ class ExecPlanReader : public arrow::RecordBatchReader {
     }
 
     plan_status_ = PLAN_FINISHED;
-    plan_.reset();
-    sink_gen_ = arrow::MakeEmptyGenerator<std::optional<compute::ExecBatch>>();
+    // plan_.reset();

Review Comment:
   It's a temporary change to figure out if this is, indeed, what fixes one or more of the `head()` related failures! (It's looking promising so far although I'd like to understand why...)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org